Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Fix 1d consolidation test (#12030) #12041

Merged
merged 12 commits into from
Feb 13, 2024

Conversation

WPK4FEM
Copy link
Contributor

@WPK4FEM WPK4FEM commented Feb 9, 2024

📝 Description
Enabled 1D consolidation test.
Simplified stage setup ( only 1 .mdpa file and 1 material file remain )
Stages end exactly at the proposed dimensionless times.

README.md file added together with picture of the test geometry and boundary conditions.

@WPK4FEM WPK4FEM added Testing Documentation GeoMechanics Issues related to the GeoMechanicsApplication labels Feb 9, 2024
@WPK4FEM WPK4FEM self-assigned this Feb 9, 2024
Copy link
Contributor

@indigocoral indigocoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @avdg81 and @WPK4FEM for fixing the test, adding documentation and also removing the unnecessary files. Great work. I only have minor suggestions and also, a question.

This test consists of 78 6-noded elements (using the SmallStrainUPwDiffOrderElement2D6N class) of b x h = 0.1 x 1.0 meter. A
schematic representation can be found in the figure below:

![MeshStructure](MeshStructure.svg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The figure is really good. Thanks for putting it with the documentation. Maybe just a suggestion:
Do you think it makes sense if we also show the amount of the load on top of the load? And maybe also the dimension of the soil column on the figure? I think this would help to get most of the information needed by just looking at the figure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried to change according to the comments. Please check again.

Copy link
Contributor

@avdg81 avdg81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for thoroughly cleaning up, documenting and reviving this test. It is much more readable now and it is no longer skipped during automatic test runs. Well done!

@avdg81 avdg81 merged commit 0778ac4 into master Feb 13, 2024
15 of 17 checks passed
@avdg81 avdg81 deleted the geo/12030-fix-1d-consolidation-test branch February 13, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation GeoMechanics Issues related to the GeoMechanicsApplication Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GeoMechanicsApplication] Fix the 1D consolidation benchmark test and understand its results
3 participants