Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TrilinosApplication] Enforce non-zeros values in graph when doing BtDBProductOperation during constraint computation #12046

Merged

Conversation

loumalouomega
Copy link
Member

📝 Description

This update introduces a critical improvement in the constraint computation process, specifically during the BtDBProductOperation. Previously, the computation faced failures in certain scenarios due to the absence of values within the graph. This was a consequence of Epetra's default behavior, which removes null values from the graph to conserve memory. While this approach is memory-efficient, it has been identified as a potential source of errors during assembly and the equation solving phases.

To address this issue, we have implemented a mechanism to enforce the presence of non-zero values in the graph during the BtDBProductOperation. This enhancement is aimed at preventing the computation failures by ensuring that the graph maintains the necessary values for a successful assembly and system solving process. By doing so, we enhance the robustness of the computation and eliminate the errors associated with missing graph values.

🆕 Changelog

…tDBProductOperation` during constraint computation
@loumalouomega loumalouomega added Applications Hotfix External library Parallel-MPI Distributed memory parallelism for HPC / clusters HPC High Performance Computing labels Feb 12, 2024
@loumalouomega loumalouomega requested review from a team as code owners February 12, 2024 10:42
@loumalouomega
Copy link
Member Author

@pooyan-dadvand , @roigcarlo can you take a look?

@loumalouomega loumalouomega merged commit 3d9c3c9 into master Feb 16, 2024
16 of 17 checks passed
@loumalouomega loumalouomega deleted the trilinos/enforce-non-zeros-b&s-BtDBProductOperation branch February 16, 2024 14:34
@loumalouomega
Copy link
Member Author

Thanks @ddiezrod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Applications External library Hotfix HPC High Performance Computing Parallel-MPI Distributed memory parallelism for HPC / clusters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants