[Releases][MedApplication] Adding Med Application support for windows. #12049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roigcarlo
requested review from
philbucher and
sunethwarna
and removed request for
a team
sunethwarna
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Thanks a lot @roigcarlo. I hope @philbucher is also ok with this :)
philbucher
approved these changes
Feb 12, 2024
| @@ -362,6 +362,9 @@ class MedModelPartIO::MedFileHandler | |||
| // read only by default, unless other settings are specified | |||
| med_access_mode open_mode; | |||
|
|
|||
| // Fix to allow windows conversion from whatever eldritch format is using to something convertible to c_str() | |||
| std::string med_file_mame{rFileName.string()}; | |||
There was a problem hiding this comment.
a f**k, now I see it now. I`ll Fix it later :P
philbucher
reviewed
Feb 12, 2024
| @@ -371,7 +374,9 @@ class MedModelPartIO::MedFileHandler | |||
| // basic checks if the file is compatible with the MED library | |||
| med_bool hdf_ok; | |||
| med_bool med_ok; | |||
| const med_err err = MEDfileCompatibility(rFileName.c_str(), &hdf_ok, &med_ok); | |||
|
|
|||
| const med_err err = MEDfileCompatibility(med_file_mame.c_str(), &hdf_ok, &med_ok); | |||
There was a problem hiding this comment.
maybe rFileName.string().c_str() would also work 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This allows the MedApplication to be compiled in windows. Also added the necessary files to be able to release it as a pip package.
Ping @Marco1410 because you use salome
Also ping @philbucher @sunethwarna you can find how to compile the med in win in the dockerfile.
🆕 Changelog
Med compilable in win