[Hotfix][Core] Edge based data structure hotfix #12059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbucher
reviewed
Feb 13, 2024
Co-authored-by: Philipp Bucher <philipp.bucher@tum.de>
loumalouomega
previously approved these changes
Feb 13, 2024
philbucher
reviewed
Feb 13, 2024
| @@ -677,7 +677,6 @@ class EdgeBasedDataStructure | |||
|
|
|||
| // Get position in the column indices vector as this is the same one to be used in the values vector | |||
| const IndexType ij_col_index = GetColumVectorIndex(aux_i_id, aux_j_id); | |||
| KRATOS_ERROR_IF(ij_col_index < 0) << "Column index cannot be found for ij-edge " << GlobalIdI << "-" << GlobalIdJ << "." << std::endl; | |||
There was a problem hiding this comment.
@rubenzorrilla this can never happen for an unsigned type
I think using std::optional would be nice here
There was a problem hiding this comment.
Sure. Most probably this is a leftover from a very first implementation or debugging. Let me merge this as it is to solve the Intel compiler issue and explore the std::optional in a separate branch.
philbucher
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
std::size_tnegative initialization.Closes #12017