Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Added missing include to GeoStructalBaseElement #12070

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

rfaasse
Copy link
Contributor

@rfaasse rfaasse commented Feb 14, 2024

📝 Description
Since the header file of the GeoStructalBaseElement uses some variables defined in geo_mechanics_application_variables.h, the include needs to be in the header.

…ader, since variables were also used in the header
@rfaasse rfaasse added Compilation GeoMechanics Issues related to the GeoMechanicsApplication labels Feb 14, 2024
@rfaasse rfaasse self-assigned this Feb 14, 2024
@rfaasse rfaasse linked an issue Feb 14, 2024 that may be closed by this pull request
@rfaasse rfaasse changed the title [GeoMechanicsApplication] Moved geo_mechanics_application_variables.h include from source to header [GeoMechanicsApplication] Added missing include to GeoStructalBaseElement Feb 14, 2024
@rfaasse rfaasse requested a review from avdg81 February 14, 2024 12:49
@rfaasse rfaasse marked this pull request as ready for review February 14, 2024 12:50
Copy link
Contributor

@avdg81 avdg81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Note that I have approved the PR, but I propose to wait until @rubenzorrilla confirms this PR fixes the issue on his side. Thanks.

@Rbravo555
Copy link
Member

With this fix, I have now compiled without issues using this environment:

  • OS: Ubuntu 22.04.3 LTS
  • Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
  • Branch: master
  • Python 3.10.12

Copy link
Member

@rubenzorrilla rubenzorrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we can go ahead if it works in @Rbravo555 's machine (we got the very same error).

@rfaasse rfaasse merged commit 24663ba into master Feb 14, 2024
16 of 17 checks passed
@rfaasse rfaasse deleted the geo/12063-fix-compilation-issue branch February 14, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compilation GeoMechanics Issues related to the GeoMechanicsApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeoMechanicsApplication Compilation issue
4 participants