Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Clean up and refactor FindConditionsNeighboursProcess #12071

Merged
merged 67 commits into from
Feb 22, 2024
Merged

[Core] Clean up and refactor FindConditionsNeighboursProcess #12071

merged 67 commits into from
Feb 22, 2024

Conversation

loumalouomega
Copy link
Member

@loumalouomega loumalouomega commented Feb 14, 2024 •
edited
Loading

📝 Description

This PR updates to the last standards the FindConditionsNeighboursProcess.

🆕 Changelog

@loumalouomega loumalouomega added Cleanup Kratos Core Parallel-SMP Shared memory parallelism with OpenMP or C++ Threads FastPR This Pr is simple and / or has been already tested and the revision should be fast Refactor When code is moved or rewrote keeping the same behavior labels Feb 14, 2024
@loumalouomega loumalouomega requested a review from a team as a code owner February 14, 2024 17:25
@loumalouomega loumalouomega requested review from a team as code owners February 14, 2024 21:52
jcotela and others added 18 commits February 22, 2024 11:52
@jcotela @loumalouomega
Minor updates
1122a8e
@jcotela @loumalouomega
Using any
aba7ba3
@jcotela @loumalouomega
Require root model part
2a1429a
@jcotela @loumalouomega
Cleaning up
f7ff6b3
@jcotela @loumalouomega
Avoid element copy
45ba929
@jcotela @loumalouomega
Add condition check
b69174c
@jcotela @loumalouomega
Fix wrong check
5a60dd3
@jcotela @loumalouomega
Remove duplicate check
e72fc0d
@jcotela @philbucher @loumalouomega
Update applications/MeshingApplication/custom_utilities/linear_to_qua…
122a713 
…dratic_tetrahedra_mesh_converter_utility.cpp

Co-authored-by: Philipp Bucher <philipp.bucher@tum.de>
@jcotela @philbucher @loumalouomega
Update applications/MeshingApplication/custom_utilities/linear_to_qua…
a89bd28 
…dratic_tetrahedra_mesh_converter_utility.cpp

Co-authored-by: Philipp Bucher <philipp.bucher@tum.de>
@loumalouomega
[Core][MPI] PointerCommunicator test update
977fbac
@rfaasse @loumalouomega
[GeoMechanicsApplication] Extract plane strain and three dimensional …
c779a2a 
…stress state functionality (#12084)

Created two new stress state policies: (1) plane strain stress state policy, and (2) 3D stress state policy. Both of them provide implementations of the abstract class `StressStatePolicy`.

Using these new policies, duplicated code could be removed.

Also added some utility functions for testing.
@rubenzorrilla @loumalouomega
Skip replace if geometry-based input modeler is used
ba5f66b
@rubenzorrilla @loumalouomega
Temporary solution
a9e28ac
@loumalouomega
Revert
41d2d71
@loumalouomega
Remove constructors in python
7bb9d68
@loumalouomega
Adding Clear method
04c77b7
@loumalouomega
Moving RetrieveConditionsNeighbourConditionsIds to utilities
5bffe9b
@loumalouomega loumalouomega requested review from a team as code owners February 22, 2024 10:52
@loumalouomega
Copy link
Member Author

@rubenzorrilla I think I applied all your suggestions

rubenzorrilla
rubenzorrilla reviewed Feb 22, 2024
View reviewed changes
kratos/processes/find_conditions_neighbours_process.cpp

void FindConditionsNeighboursProcess::ClearNeighbours()
{
// Call Clear method
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can throw a warning in here to inform the user that the Clear must be used instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@rubenzorrilla
Copy link
Member

@rubenzorrilla I think I applied all your suggestions

I think so too. Thanks.

rubenzorrilla
rubenzorrilla approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@rubenzorrilla rubenzorrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. No more concerns from my side.

@loumalouomega
Copy link
Member Author

Great. No more concerns from my side.

@loumalouomega loumalouomega merged commit 1c10370 into master Feb 22, 2024
15 of 17 checks passed
@loumalouomega loumalouomega deleted the core/clean-up-refactor-FindConditionsNeighboursProcess branch February 22, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenzorrilla rubenzorrilla rubenzorrilla approved these changes

@roigcarlo roigcarlo Awaiting requested review from roigcarlo

Assignees
No one assigned
Labels
Cleanup FastPR This Pr is simple and / or has been already tested and the revision should be fast Kratos Core Parallel-SMP Shared memory parallelism with OpenMP or C++ Threads Refactor When code is moved or rewrote keeping the same behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@loumalouomega @rubenzorrilla @jcotela @rfaasse