-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fluid] Skip replace elements&conditions if geometry-based input modeler is used #12089
[Fluid] Skip replace elements&conditions if geometry-based input modeler is used #12089
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not break anything in our side, and the change makes sense to me, approving. 👍
Agreed with @ddiezrod, but I'm adding the API breaker tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I also wanted this :) thansk @rubenzorrilla
Well, I'm not sure we're breaking the API but changing the default behavior. Let me add the behavior change tag too. |
ca128d3
@marcnunezc @inigolcanalejo I think that the test crashing in here is yours. The point is that the primal solution solver in the optimizing is assuming the input model part to be the one from the previous iteration (makes perfect sense). The point is, as far as I understand, that it assumes replacing the elements & conditions (at each iteration!). This is even trickier as the To prevent the test crashing, I added a Also pinging @sunethwarna as this uses the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rubenzorrilla
📝 Description
With this PR we will skip the elements and conditions replace done by the
ReplaceElementsAndConditionsProcess
for theuse_input_model_part
option in the I/O.Note that this is aligned with the geometry-based I/O we are targeting with the new modelers.
@KratosMultiphysics/altair as far as I understand this shouldn't break anything in your side. In any case, I'm pinging you to confirm that this doesn't break any specific thing in your custom multistage.
PD: The change of setting the echo level to the strategy after creating it sneaked in 😅. I'd keep it there.