-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GeoMechanicsApplication] Initialize stress state policies of the UPw diff order elements at construction #12091
Merged
rfaasse
merged 62 commits into
master
from
geo/12056-initialize-stress-state-policies-at-element-construction
Feb 26, 2024
Merged
[GeoMechanicsApplication] Initialize stress state policies of the UPw diff order elements at construction #12091
rfaasse
merged 62 commits into
master
from
geo/12056-initialize-stress-state-policies-at-element-construction
Feb 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e axisymmetric policy and added a test for calculating the B matrix
…tress-state-functionality
# Conflicts: # applications/GeoMechanicsApplication/custom_elements/small_strain_U_Pw_diff_order_axisymmetric_element.hpp
… which throws for the axisymmetric case
…lane-and-three-d-stress-state' into geo/12004-extract-plane-and-three-d-stress-state
… Small Strain UPw files, Renamed the class and the file names and did some refactoring
…nge strain. Moreover, used std::unique_ptr instead of unique_ptr in clone functions
…sistent (to make it easier to see later how to refactor into a member)
Base automatically changed from
geo/12004-extract-plane-and-three-d-stress-state
to
master
February 21, 2024 12:27
…-at-element-construction
…e-stress-state-policies-at-element-construction
…e-stress-state-policies-at-element-construction
…e-stress-state-policies-at-element-construction # Conflicts: # applications/GeoMechanicsApplication/custom_elements/small_strain_U_Pw_diff_order_axisymmetric_element.hpp # applications/GeoMechanicsApplication/custom_elements/updated_lagrangian_U_Pw_diff_order_axisymmetric_element.hpp
markelov208
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Richard, nice and clear. There is nothing to catch my eyes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR adds the stress state strategy as a member pointer to the interface in the UPw diff order elements. This means that there is no functionality in the axisymmetric elements left that is not captures in the stress state policy, so we can remove them.
Note that for the other UPw elements, a similar strategy still needs to be done. It is split up in two PRs, to limit the the scope of each PR.