Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Poro] Cleanup and refactoring of the App #12104

Merged
merged 13 commits into from
Feb 22, 2024

Conversation

ipouplana
Copy link
Member

@ipouplana ipouplana commented Feb 22, 2024

📝 Description
This PR is meant to cleanup and refactor the PoromechanicsApplication as a first step towards the future addition of the two-phase flow in porous media formulation. That means that this PR must be merged before the two-phase flow formulation is added. All the previous tests pass in FullDebug mode.

🆕 Changelog

  • The current formulation is moved into a folder named one-phase_flow
  • The constitutive laws are split between two folders: continuum_laws and interface_element_laws
  • All references to "water" are replaced by "liquid" to be consistent
  • Some variables have been renamed to be more general
  • Two variables: NODAL_WATER_PRESSURE_GRADIENT and NODAL_DAMAGE_VARIABLE have been removed as they were not used
  • The time integration schemes input variables have been updated to be more general
  • The new Poromechanics file paths have been updated in DamApplication too.

@ipouplana ipouplana added Cleanup Applications Refactor When code is moved or rewrote keeping the same behavior labels Feb 22, 2024
@ipouplana ipouplana merged commit 50ebdf1 into master Feb 22, 2024
15 of 17 checks passed
@ipouplana ipouplana deleted the poro/cleanup-and-reorganization branch February 22, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Applications Cleanup Refactor When code is moved or rewrote keeping the same behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants