[Core] Forbid Renaming ModelParts

[matekelemen]

Description

ModelPart allows resetting its name, which breaks sub model part containers. These containers are hash maps that generate their hashes based on the model part's name. However, when a ModelPart is renamed, the sub model part container of its parent doesn't update its hash map, which completely breaks access to sub model parts.

Changelog

• remove std::string& ModelPart::Name() (the mutable overload)
• remove Model::RenameModelPart and its corresponding test

[loumalouomega]

What about update the hash map?

[loumalouomega]

Requires further discussion

[loumalouomega]

What about update the hash map?

We can make the Name() method const and update the implementation of the Rename method

[philbucher]

makes full sense to me, I think this is a leftover from early Model days

[philbucher]

yikes, time to go 👋

[loumalouomega]

In this particualr case yes, it makes sense

[loumalouomega]

add_model_part_to_python.cpp:46:25: error: no match for 'operator=' (operand types are 'const std::string' {aka 'const std::__cxx11::basic_string<char>'} and 'const std::string' {aka 'const std::__cxx11::basic_string<char>'})

Looks like python binding is a bit hardcoded

[roigcarlo]

Algo agree with this one

[matekelemen]

What about update the hash map?

We can make the Name() method const and update the implementation of the Rename method

Is there a valid use case tho? I'd rather just remove the entire thing than move ModelParts around.

[loumalouomega]

What about update the hash map?

We can make the Name() method const and update the implementation of the Rename method

Is there a valid use case tho? I'd rather just remove the entire thing than move ModelParts around.

Well, i guess if the method was there is beacuse somone was using it