Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Clean up and refactor ApplyConstantScalarValueProcess #12163

Merged
merged 7 commits into from
Apr 17, 2024
Merged

[Core] Clean up and refactor ApplyConstantScalarValueProcess #12163

merged 7 commits into from
Apr 17, 2024

Conversation

loumalouomega
Copy link
Member

📝 Description

Clean up and refactor ApplyConstantScalarValueProcess, separating code to source file and improve refactor includes to reduce code duplication. Refactor with modern KRATOS_ERROR.

🆕 Changelog

@loumalouomega loumalouomega added Cleanup Kratos Core FastPR This Pr is simple and / or has been already tested and the revision should be fast Refactor When code is moved or rewrote keeping the same behavior Header/source refactor Move code from header only to header/source structure labels Mar 7, 2024
@loumalouomega loumalouomega requested a review from a team as a code owner March 7, 2024 12:41
rubenzorrilla
rubenzorrilla reviewed Mar 8, 2024
View reviewed changes
Copy link
Member

@rubenzorrilla rubenzorrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside of the comment about the GeoMechanicsApplication change the rest is aesthetics and refactor.

@loumalouomega
Copy link
Member Author

Aside of the comment about the GeoMechanicsApplication change the rest is aesthetics and refactor.

Does my comment convinced you?

@loumalouomega
Copy link
Member Author

Hello @rubenzorrilla

@loumalouomega
Copy link
Member Author

Hello @rubenzorrilla

👋

@loumalouomega
Copy link
Member Author

Ping @rubenzorrilla

@loumalouomega
Copy link
Member Author

Hello @rubenzorrilla @roigcarlo

@loumalouomega loumalouomega merged commit 09dccbc into master Apr 17, 2024
13 checks passed
@loumalouomega loumalouomega deleted the core/clean-up-refactor-ApplyConstantScalarValueProcess branch April 17, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenzorrilla rubenzorrilla rubenzorrilla approved these changes

@roigcarlo roigcarlo Awaiting requested review from roigcarlo

Assignees
No one assigned
Labels
Cleanup FastPR This Pr is simple and / or has been already tested and the revision should be fast Header/source refactor Move code from header only to header/source structure Kratos Core Refactor When code is moved or rewrote keeping the same behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loumalouomega @rubenzorrilla