[GeoMechanicsApplication] Extract a static utility function for the calculation of the Compressibility Matrix (C) #12232

markelov208 · 2024-03-28T15:06:23Z

📝 Description

A utility function which can calculate the compressibility matrix, such that this can be re-used and steps are taken towards the addition of the #12067.

🆕 Changelog

The calculation of the compressibility matrix is available as a utility function, which takes the pressure shape function, integration coefficient and the inverse Biot Modulus for all integration points as input and returns the element matrix.
This calculation is defined once and re-used at all locations where this calculation is done in the geomechanics application.
The utility function is documented and unit-tested.

…FIC ondition

rfaasse

This is a neat PR and moves all instances of the formula to a single location, very nice! I just have a few suggestions, but only minor ones.

applications/GeoMechanicsApplication/custom_conditions/U_Pw_normal_flux_FIC_condition.cpp

applications/GeoMechanicsApplication/custom_utilities/transport_equation_utilities.hpp

applications/GeoMechanicsApplication/tests/cpp_tests/test_compressibility_matrix.cpp

markelov208

Richard, thank you very much for the quick review and useful suggestions.

applications/GeoMechanicsApplication/custom_conditions/U_Pw_normal_flux_FIC_condition.cpp

applications/GeoMechanicsApplication/custom_utilities/transport_equation_utilities.hpp

applications/GeoMechanicsApplication/tests/cpp_tests/test_compressibility_matrix.cpp

avdg81

This cleans up nicely again. Thank you very much for the time and effort you have put into this. I only have a few very minor remarks and a question.

applications/GeoMechanicsApplication/custom_elements/transient_Pw_interface_element.cpp

applications/GeoMechanicsApplication/custom_utilities/transport_equation_utilities.hpp

applications/GeoMechanicsApplication/custom_utilities/README.md

applications/GeoMechanicsApplication/custom_utilities/transport_equation_utilities.hpp

markelov208

Anne, thank you very much for your comment. DtPressureCoefficient has been removed from CalculateCompressibilityMatrix function that makes the function simpler.

rfaasse

Thank you for incorporating the changes! Looks good to go from my perspective!

avdg81

I have just one small suggestion as a result of your most recent changes. Apart from that, we're ready to go if you'd ask me :-)

applications/GeoMechanicsApplication/custom_utilities/transport_equation_utilities.hpp

avdg81

This looks good to me, so please merge :-)

Gennady Markelov added 9 commits March 28, 2024 14:25

added CalculateCompressibilityMatrix function

7982605

introduced CalculateCOmpressibilityMatrix function

2e4211f

updated README.md

2f61c70

added tests for CalculateCompressibilityMatrix

22adaa9

removed unused variable DynamicViscosityInverse

9671c13

removed commented lines

f52b1d5

removed commented lines and added CalculateCompressibilityMatrix for …

620ab8d

…FIC ondition

removed commented lines

10ce7c0

reverted noalias(rPMatrix)

1651eeb

markelov208 requested review from rfaasse and avdg81 March 29, 2024 05:04

markelov208 self-assigned this Mar 29, 2024

rfaasse reviewed Mar 29, 2024

View reviewed changes

changed to meet the review comments

a5f6bee

markelov208 commented Mar 29, 2024

View reviewed changes

Gennady Markelov added 2 commits March 29, 2024 17:16

added comment on 1/6 factor

7787253

Merge branch 'master' into geo/extract-utility-function-C

99a00db

avdg81 reviewed Apr 2, 2024

View reviewed changes

Gennady Markelov added 2 commits April 2, 2024 11:45

corrected Biot name

cc48b08

moved DtPressureCoefficient out of CalculateCompressibilityMatrix

130c57c

markelov208 commented Apr 2, 2024

View reviewed changes

markelov208 requested review from avdg81 and rfaasse April 2, 2024 11:30

rfaasse previously approved these changes Apr 2, 2024

View reviewed changes

avdg81 reviewed Apr 2, 2024

View reviewed changes

applications/GeoMechanicsApplication/custom_utilities/transport_equation_utilities.hpp Outdated Show resolved Hide resolved

removed redundant include

49713bf

markelov208 dismissed rfaasse’s stale review via 49713bf April 2, 2024 13:11

avdg81 approved these changes Apr 2, 2024

View reviewed changes

markelov208 merged commit 0c77a49 into master Apr 2, 2024
11 checks passed

markelov208 deleted the geo/extract-utility-function-C branch April 2, 2024 15:07

rfaasse linked an issue Apr 3, 2024 that may be closed by this pull request

[GeoMechanicsApplication] Extract a static utility function for the calculation of the Compressibility Matrix (C) #12245

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GeoMechanicsApplication] Extract a static utility function for the calculation of the Compressibility Matrix (C) #12232

[GeoMechanicsApplication] Extract a static utility function for the calculation of the Compressibility Matrix (C) #12232

markelov208 commented Mar 28, 2024 •

edited

Loading

rfaasse left a comment

markelov208 left a comment

avdg81 left a comment

markelov208 left a comment

rfaasse left a comment

avdg81 left a comment

avdg81 left a comment

[GeoMechanicsApplication] Extract a static utility function for the calculation of the Compressibility Matrix (C) #12232

[GeoMechanicsApplication] Extract a static utility function for the calculation of the Compressibility Matrix (C) #12232

Conversation

markelov208 commented Mar 28, 2024 • edited Loading

rfaasse left a comment

Choose a reason for hiding this comment

markelov208 left a comment

Choose a reason for hiding this comment

avdg81 left a comment

Choose a reason for hiding this comment

markelov208 left a comment

Choose a reason for hiding this comment

rfaasse left a comment

Choose a reason for hiding this comment

avdg81 left a comment

Choose a reason for hiding this comment

avdg81 left a comment

Choose a reason for hiding this comment

markelov208 commented Mar 28, 2024 •

edited

Loading