Optimize Node Processing in ROM Basis Setting #12240
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces performance optimizations to the node processing logic in
rom_analysis.py
, specifically for setting the Reduced Order Model (ROM) basis. The original implementation, which iterated over all nodes usingnp.where
within a loop, was suboptimal for large datasets.Changes
File Modified
rom_analysis.py
Key Modifications
node_id_to_index
), mapping each node ID to its index in thenode_ids
array. This optimizes the retrieval of node indices during the main processing loop.node_id_to_index
mapping for efficient index lookup, thereby reducing computational overhead.Benefits
Additional Notes
rom_analysis.py
module.