New Rom Utility Functions #12274
Merged
New Rom Utility Functions #12274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rbravo555
reviewed
Apr 16, 2024
| return Kratos::RomAuxiliaryUtilities::GetNodalNeighbouringElementIds(rModelPart, rGivenModelPart);}) | ||
| .def_static("GetNodalNeighbouringElementIds", [](Kratos::ModelPart& rModelPart, const std::vector<Kratos::IndexType>& rNodeIds, bool retrieveSingleNeighbour) { | ||
| return Kratos::RomAuxiliaryUtilities::GetNodalNeighbouringElementIds(rModelPart, rNodeIds, retrieveSingleNeighbour);}) | ||
| .def_static("GetNodalNeighbouringConditionIds", &RomAuxiliaryUtilities::GetNodalNeighbouringConditionIds) | ||
| .def_static("GetConditionIdsNotInHRomModelPart", &RomAuxiliaryUtilities::GetConditionIdsNotInHRomModelPart) |
There was a problem hiding this comment.
why are we adding a return here? I had not seen return in other pybind stuff
| const auto& r_elem = r_neigh_elements[i]; | ||
| parent_ids_set.insert(r_elem.Id() - 1); | ||
| break; | ||
| } |
There was a problem hiding this comment.
This +1 in the condId(line 513) and r_elem.Id()-1 in line 519 are related to the difference in ids in numpy and in Kratos? let us mark it as #FIXME, to have it in mind for an upcoming PR fixing all these indexes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR introduces a set of new utility functions to the
RomAuxiliaryUtilitiesclass.Description
GetHRomConditionParentsIds
GetNodalNeighbouringElementIds
GetNodalNeighbouringConditionIds
GetNodalNeighbouringElementIdsbut targets conditions adjacent to given nodes.These utilities were particularly valuable for cosimulation scenarios where the transfer on the interface becomes a challenge.