[SiApp] p-norm damage resp #12373
Open
[SiApp] p-norm damage resp #12373
+497
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunethwarna
reviewed
May 25, 2024
There was a problem hiding this comment.
Thanks @Igarizza. Following are my comments:
-
I know we don't have any small finite diferencing unit tests for the
MeasurementResidualResponseFunction, but at least we can try adding a small finite differencing unit tests for theMeasurementResidualPNorm. -
Just an after thought, If we say
p_coefficient = 1, then it is the existingMeasurementResidualPNormryt (apart from the1/pat the end? should we unify these two?
Apart from above, I only have some minor comments.
...emIdentificationApplication/custom_sensors/measurement_residual_p_norm_response_function.cpp
Outdated
Show resolved
Hide resolved
...emIdentificationApplication/custom_sensors/measurement_residual_p_norm_response_function.cpp
Outdated
Show resolved
Hide resolved
...emIdentificationApplication/custom_sensors/measurement_residual_p_norm_response_function.cpp
Outdated
Show resolved
Hide resolved
...emIdentificationApplication/custom_sensors/measurement_residual_p_norm_response_function.cpp
Outdated
Show resolved
Hide resolved
...emIdentificationApplication/custom_sensors/measurement_residual_p_norm_response_function.cpp
Outdated
Show resolved
Hide resolved
...stemIdentificationApplication/custom_sensors/measurement_residual_p_norm_response_function.h
Outdated
Show resolved
Hide resolved
...plication/python_scripts/sensor_sensitivity_solvers/system_identification_static_analysis.py
Outdated
Show resolved
Hide resolved
sunethwarna
added
Optimization
sunethwarna
reviewed
Jun 18, 2024
applications/SystemIdentificationApplication/custom_python/add_custom_sensors_to_python.cpp
Outdated
Show resolved
Hide resolved
| @@ -36,7 +37,11 @@ def Initialize(self): | |||
| model_part.ProcessInfo[KratosSI.ADAPT_PERTURBATION_SIZE] = sensor_settings["adapt_perturbation_size"].GetBool() | |||
| self.listof_sensors = GetSensors(model_part, sensor_settings["list_of_sensors"].values()) | |||
|
|
|||
| self.measurement_residual_response_function = KratosSI.Sensors.MeasurementResidualResponseFunction() | |||
| aggregation_technique = sensor_settings["aggregation_technique"].GetString() | |||
There was a problem hiding this comment.
I don't see how this aggregation_technique variable is used?
There was a problem hiding this comment.
it is left over, I will remove
…_custom_sensors_to_python.cpp Co-authored-by: Suneth Warnakulasuriya <suneth.warna@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
PR implments a new aggregation strategy for damage detection resonse. Implementation creates new cpp object for p-norm calculations. In json file one can specify the sensor settings to use p-norm for weighting the sensor contribution.
Please mark the PR with appropriate tags:
🆕 Changelog
Please summarize the changes in one list to generate the changelog:
E.g.