[All][Core][Model] CreateModelPart new behavior #9598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenzorrilla
added
Kratos Core
Behaviour Change
|
does this interfere or interact in any other way with #7108? |
As far as I understand it shouldn't. |
RiccardoRossi
approved these changes
Feb 10, 2022
rubenzorrilla
deleted the
all/model-modify-create-model-part-behavior
branch
This was referenced Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
As it has been discussed in #9258, the creation of model parts must happen at the modelers stage in order to enable the multistage simulation (not at the solver instantiation as we're doing right now).
Changing the
CreateModelPartmethod of theModelas suggested in here will ease the transition period. Long story short, right now we were throwing an error if the model part was already existing. With this change we will issue a warning and return the already existing model part.Backwards compatibility is ensured as we were throwing an error so far.