-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Made Condition::GetIntegrationMethod const #9769
[Core] Made Condition::GetIntegrationMethod const #9769
Conversation
@loumalouomega I've seen some of your implementations. Just for you to know |
Okay, sorry for the previous message, I thought this was al another pr |
This reverts commit e5712e1.
…-GetIntegrationMethod
…e/removed-deprecated-GetIntegrationMethod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on behalf of the https://github.com/orgs/KratosMultiphysics/teams/technical-committee.
Please merge the other one first.
@KratosMultiphysics/all
AND
|
This PR changes the function signature from
to
Deprecation warning
This breaks the API so a deprecation warning has been added for some time (See #9789).
@KratosMultiphysics/all :
🆕 Changelog
How to fix my condition?
If this change breaks any of your
Condition
s, simply add the const in yourGetIntegrationMethod
declaration in the.h
header file:You will also need to modify the method definition in the
cpp
source file if it is separate from the declaration: