Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Made Condition::GetIntegrationMethod const #9769

Merged

Conversation

EduardGomezEscandell
Copy link
Contributor

@EduardGomezEscandell EduardGomezEscandell commented Mar 16, 2022

This PR changes the function signature from

virtual IntegrationMethod Condition::GetIntegrationMethod();

to

virtual IntegrationMethod Condition::GetIntegrationMethod() const;

Deprecation warning
This breaks the API so a deprecation warning has been added for some time (See #9789).

@KratosMultiphysics/all :

  • This PR will be merged on April 19th, 2022.
  • Applications in the CI run have been adapted.
  • Any other applications and forks will break.

🆕 Changelog

  • Makes GetIntegrationMethod method of Condition const
  • Changed overrides to const

How to fix my condition?
If this change breaks any of your Conditions, simply add the const in your GetIntegrationMethod declaration in the .h header file:

- IntegrationMethod GetIntegrationMethod() override
+ IntegrationMethod GetIntegrationMethod() const override

You will also need to modify the method definition in the cpp source file if it is separate from the declaration:

- IntegrationMethod YourCondition::GetIntegrationMethod() {
+ IntegrationMethod YourCondition::GetIntegrationMethod() const {

@EduardGomezEscandell EduardGomezEscandell added Kratos Core Deprecated Leftover Something remaining from a previous PR that must be cleaned labels Mar 16, 2022
@EduardGomezEscandell EduardGomezEscandell requested a review from a team as a code owner March 16, 2022 10:17
@EduardGomezEscandell EduardGomezEscandell self-assigned this Mar 16, 2022
@EduardGomezEscandell EduardGomezEscandell requested a review from a team as a code owner March 16, 2022 10:50
@EduardGomezEscandell EduardGomezEscandell requested a review from a team as a code owner March 16, 2022 13:40
@AlejandroCornejo
Copy link
Member

@loumalouomega I've seen some of your implementations. Just for you to know

@loumalouomega
Copy link
Member

loumalouomega commented Mar 16, 2022

@loumalouomega I've seen some of your implementations. Just for you to know

Okay, sorry for the previous message, I thought this was al another pr

@EduardGomezEscandell EduardGomezEscandell changed the title [Core] Removed non-const Condition::GetIntegrationMethod [Core] Made Condition::GetIntegrationMethod const Mar 23, 2022
@EduardGomezEscandell EduardGomezEscandell added this to Upcoming in Deprecations Mar 23, 2022
@EduardGomezEscandell EduardGomezEscandell added this to To do in LEGACY Technical Committee via automation Mar 28, 2022
@EduardGomezEscandell EduardGomezEscandell moved this from To do to Next meeting todo in LEGACY Technical Committee Mar 28, 2022
Copy link
Member

@roigcarlo roigcarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of the https://github.com/orgs/KratosMultiphysics/teams/technical-committee.

Please merge the other one first.

@roigcarlo roigcarlo moved this from Next meeting todo to In progress in LEGACY Technical Committee Mar 29, 2022
@EduardGomezEscandell
Copy link
Contributor Author

@KratosMultiphysics/all
A reminder that this PR will be merged right after easter. You will be affected if:

  • Your application is not in the CI.
  • You have your own fork.

AND

  • You have overloaded Condition::GetIntegrationMethod

@EduardGomezEscandell EduardGomezEscandell merged commit 5b0756e into master Apr 20, 2022
@EduardGomezEscandell EduardGomezEscandell deleted the core/removed-deprecated-GetIntegrationMethod branch April 20, 2022 15:20
LEGACY Technical Committee automation moved this from In progress to Done Apr 20, 2022
Deprecations automation moved this from Upcoming to Already Done Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Breaker Deprecated Kratos Core Leftover Something remaining from a previous PR that must be cleaned
Projects
Deprecations
  
Already Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants