-
Notifications
You must be signed in to change notification settings - Fork 5
Story 51 - Un-Assigned Patients Notification + Boilerplate Setup #147
Conversation
Visit the preview URL for this PR (updated for commit 230561b): https://soen-390-ba781--pr147-story-51-kqyz7jju.web.app (expires Mon, 04 Apr 2022 00:13:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Codecov Report
@@ Coverage Diff @@
## dev #147 +/- ##
==========================================
- Coverage 56.24% 55.95% -0.28%
==========================================
Files 51 53 +2
Lines 1364 1412 +48
Branches 344 347 +3
==========================================
+ Hits 767 790 +23
- Misses 593 618 +25
Partials 4 4
Continue to review full report at Codecov.
|
dispatchDoctor({ title: 'Title Test', message: 'testing', userId: state.id }); | ||
}; | ||
|
||
useEffect(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we unsubscribe from firestore when you unmount the component here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
setOpen(false); | ||
}; | ||
|
||
useEffect(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, I believe we need to make sure to unsubscribe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i agree with mimi's comments or else it looks good!
Related Issue
Proposed Changes (Description)
In the admin dashboard, admins will need to be notified if there are more patients than the number of available slots (based on the nb of current patients and doctors). This notification will allow them to modify settings, or add more medical staff.
There's no need to send a pop-up notification to the admin for it. A simple red dot on the UnAssigned Patients Tab is enough.
& Boilerplate Setup for Notifications System (Cloud Functions that will be used for the other user stories)
Checklist