This repository has been archived by the owner on May 2, 2022. It is now read-only.
Story 51 - Un-Assigned Patients Notification + Boilerplate Setup #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinsenecal
changed the title
|
Visit the preview URL for this PR (updated for commit 230561b): https://soen-390-ba781--pr147-story-51-kqyz7jju.web.app (expires Mon, 04 Apr 2022 00:13:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Codecov Report
@@ Coverage Diff @@
## dev #147 +/- ##
==========================================
- Coverage 56.24% 55.95% -0.28%
==========================================
Files 51 53 +2
Lines 1364 1412 +48
Branches 344 347 +3
==========================================
+ Hits 767 790 +23
- Misses 593 618 +25
Partials 4 4
Continue to review full report at Codecov.
|
MilitsaB
reviewed
Mar 27, 2022
| dispatchDoctor({ title: 'Title Test', message: 'testing', userId: state.id }); | ||
| }; | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
Shouldn't we unsubscribe from firestore when you unmount the component here?
MilitsaB
reviewed
Mar 27, 2022
| setOpen(false); | ||
| }; | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
Same here, I believe we need to make sure to unsubscribe
MilitsaB
approved these changes
Mar 28, 2022
Alexialsousa
approved these changes
Mar 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Proposed Changes (Description)
In the admin dashboard, admins will need to be notified if there are more patients than the number of available slots (based on the nb of current patients and doctors). This notification will allow them to modify settings, or add more medical staff.
There's no need to send a pop-up notification to the admin for it. A simple red dot on the UnAssigned Patients Tab is enough.
& Boilerplate Setup for Notifications System (Cloud Functions that will be used for the other user stories)
Checklist