Update v1.0.0 - Getting ready for publication #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meld/version.py
Outdated
| @@ -1,4 +1,3 @@ | |||
| # Copyright (C) 2020 Krishnaswamy Lab, Yale University | |||
|
|
|||
| __version__ = "0.3.2" | |||
|
|
|||
| __version__ = "0.4.0" | |||
There was a problem hiding this comment.
If you're going to change the function APIs, you should either (and preferably both) bump a major version number to indicate breaking changes, or use legacy_api_wrap to accept the legacy arguments (see https://github.com/theislab/scanpy/blob/master/scanpy/external/pp/_magic.py#L19 for an example).
There was a problem hiding this comment.
Also any functions with changed names ideally you would created a deprecated function mapping from old to new.
There was a problem hiding this comment.
Yeah I was wondering about this. I'd rather have the 0.x block reserved for the prepublication beta software and then just break everything for version 1.0 🤣
dburkhardt
changed the title
dburkhardt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.