Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use an svg in julia types example and fix an undef var bug #52

Merged
merged 2 commits into from
Jan 20, 2018

Conversation

KristofferC
Copy link
Owner

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 20, 2018

Codecov Report

Merging #52 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   71.42%   71.42%           
=======================================
  Files           8        8           
  Lines         434      434           
=======================================
  Hits          310      310           
  Misses        124      124
Impacted Files Coverage Δ
src/tikzdocument.jl 55.39% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef023e8...557174b. Read the comment docs.

@tpapp
Copy link
Collaborator

tpapp commented Jan 20, 2018

I wonder if it would make sense to define something like

function save_all(figname)
    pgf.save(figname * ".pdf", a)
    run(`pdf2svg $(figname * ".pdf") $(figname * ".svg")`)
    pgf.save(figname * ".tex", a)
    nothing
end

in the @setup of each file, for DRY.

@KristofferC
Copy link
Owner Author

Yeah, I agree.

@KristofferC
Copy link
Owner Author

added

@tpapp
Copy link
Collaborator

tpapp commented Jan 20, 2018

LGTM.

@KristofferC KristofferC merged commit 46307bd into master Jan 20, 2018
@tpapp tpapp mentioned this pull request Jan 22, 2018
@KristofferC KristofferC deleted the kc/stuffs branch January 8, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants