Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give in to the export #62

Merged
merged 1 commit into from
Feb 13, 2018
Merged

give in to the export #62

merged 1 commit into from
Feb 13, 2018

Conversation

KristofferC
Copy link
Owner

I got tired of looking at pgf.@pgf pgf.Axis(pgf.Plot..... So fine, let's just export it. Closes #29

@KristofferC KristofferC force-pushed the kc/export branch 2 times, most recently from ef7e378 to 288421b Compare February 12, 2018 22:16
@codecov-io
Copy link

codecov-io commented Feb 12, 2018

Codecov Report

Merging #62 into master will increase coverage by 0.35%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   77.91%   78.27%   +0.35%     
==========================================
  Files           8        8              
  Lines         471      474       +3     
==========================================
+ Hits          367      371       +4     
+ Misses        104      103       -1
Impacted Files Coverage Δ
src/PGFPlotsX.jl 58.33% <ø> (ø) ⬆️
src/tikzdocument.jl 57.04% <75%> (+1.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4211f29...688aa5d. Read the comment docs.

export Axis, GroupPlot, PolarAxis
export Plot, Plot3, Expression, EmptyLine, Coordinates,
Table, Graphics, Legend
export @pgf, print_tex, latexengine, latexengine!, CUSTOM_PREAMBLE, push_preamble!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure you want to export print_tex? the manual explicitly says that this is not something that is usually called from user code.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, true but I use it quite often in e.g. notebooks to see what the output actually is instead of round-tripping to a .tex file and I don't think print_tex will clash with anything else.

@@ -194,6 +194,9 @@ an existing PDF file with the same name.
latex_engine = latexengine(),
buildflags = vcat(DEFAULT_FLAGS, CUSTOM_FLAGS),
keep_pdf = false)
if _is_ijulia() || _is_juno() || _is_vscode()

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do? it looks like an empty if ... end block

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I think this was left on a WIP to make the background white if we are in an IDE. Will remove it.

@tpapp tpapp mentioned this pull request Feb 13, 2018
@KristofferC KristofferC merged commit 43458c7 into master Feb 13, 2018
@tpapp tpapp mentioned this pull request Feb 23, 2018
@KristofferC KristofferC deleted the kc/export branch January 8, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants