-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
give in to the export #62
Conversation
ef7e378
to
288421b
Compare
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
+ Coverage 77.91% 78.27% +0.35%
==========================================
Files 8 8
Lines 471 474 +3
==========================================
+ Hits 367 371 +4
+ Misses 104 103 -1
Continue to review full report at Codecov.
|
export Axis, GroupPlot, PolarAxis | ||
export Plot, Plot3, Expression, EmptyLine, Coordinates, | ||
Table, Graphics, Legend | ||
export @pgf, print_tex, latexengine, latexengine!, CUSTOM_PREAMBLE, push_preamble! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure you want to export print_tex
? the manual explicitly says that this is not something that is usually called from user code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, true but I use it quite often in e.g. notebooks to see what the output actually is instead of round-tripping to a .tex file and I don't think print_tex
will clash with anything else.
src/tikzdocument.jl
Outdated
@@ -194,6 +194,9 @@ an existing PDF file with the same name. | |||
latex_engine = latexengine(), | |||
buildflags = vcat(DEFAULT_FLAGS, CUSTOM_FLAGS), | |||
keep_pdf = false) | |||
if _is_ijulia() || _is_juno() || _is_vscode() | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this do? it looks like an empty if ... end
block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I think this was left on a WIP to make the background white if we are in an IDE. Will remove it.
288421b
to
688aa5d
Compare
I got tired of looking at
pgf.@pgf pgf.Axis(pgf.Plot....
. So fine, let's just export it. Closes #29