Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.0.0 Features/Roadmap - HUGE MAJOR RELEASE #144

Closed
19 tasks done
Ks89 opened this issue Jun 16, 2018 · 29 comments
Closed
19 tasks done

7.0.0 Features/Roadmap - HUGE MAJOR RELEASE #144

Ks89 opened this issue Jun 16, 2018 · 29 comments

Comments

@Ks89
Copy link
Owner

Ks89 commented Jun 16, 2018

From this summer I'm working on angular-modal-gallery 7.0.0

Expected changes 7.0.0

  • add carousel features (big feature)
  • add carousel's previews features (big feature)
  • gallery ids must be unique across the whole application, so if you are using the library in multiple components of the same application, you must use different numeric ids (I suggest 0,1,2,3, 100,101, 200, 201 and so on) BREAKING CHANGE
  • new main example with 3 pages and navigation to split carousel, modal and plain gallery
  • require rxjs >= 6 (remove rxjs-compat) BREAKING CHANGE
  • change preview's sliding behaviour (simple and cleaner then before, taken from carousel's previews) BREAKING CHANGE
  • re-write tests for previews component in modal view with the new logic
  • it will require Angular >=7 (probably also Angular 6, but this time I won't promise anything) BREAKING CHANGE
  • switch to the official ng lib features in angular-cli >= 6 with the new Angular specification BREAKING CHANGE
  • add new method into galleryservice called 'navigateGallery'
  • new doc website https://github.com/Ks89/angular-modal-gallery-2018-v7.github.io
  • update all local examples
  • add carousel, plain and modal images to readme.md
  • update stackblitz example
  • test id-validator.service
  • add configurable breakpoints to carousel's previews
  • test carousel component
  • test carousel-previews component
  • update doc website with this info (Lazy loading image URLs from the backend #141) [requested by @dbayonacode]:
    please don't use "this.images.push(img);".  When you want to modify images, you have to re-assign 
    the array to the images input because I'm using OnPush strategy to improve performance.
    So, don't do this.images.push, but instead:
    const newImageArray= ....;
    this.images = newImageArray;
    otherwise change detection won't be triggered.
    

Expected changes 7.1.0 -> 7.X.X

Next:


Feel free to propose new features.

Public branch available here 7.0.0
I want to release this major version during the autumn with angular 7 support.

@Ks89
Copy link
Owner Author

Ks89 commented Aug 9, 2018

I started to work on a new big feature: carousel

Ks89 added a commit that referenced this issue Aug 10, 2018
Ks89 added a commit that referenced this issue Aug 10, 2018
Ks89 added a commit that referenced this issue Aug 11, 2018
…e over to play/stop in a better way with autoPlay on/off #144
@Ks89
Copy link
Owner Author

Ks89 commented Aug 12, 2018

New documentation website (still not updated to 7.x.x) with better accessibility, performance and SSR support with angular-universal: https://github.com/Ks89/angular-modal-gallery-2018-v7.github.io

I'll update and publish it after the first alphas of the library :)

@Ks89
Copy link
Owner Author

Ks89 commented Aug 16, 2018

@ks89/angular-modal-gallery version 7.0.0 will require rxjs 6 (no more rxjs-compat). So the minimum version of Angular will 6.0.0 as already anticipated.

@Ks89
Copy link
Owner Author

Ks89 commented Aug 16, 2018

If angular-cli 7 will force all library developers to switch to Angular 7, also @ks89/angular-modal-gallery will require angular 7.

Ks89 added a commit that referenced this issue Oct 15, 2018
Ks89 added a commit that referenced this issue Oct 15, 2018
@Ks89 Ks89 changed the title 7.0.0 Features/Roadmap - HUGE MAJOR RELEASE [BETA.1 RELEASED!!!] 7.0.0 Features/Roadmap - HUGE MAJOR RELEASE [BETA.2 IS COMING!!!] Oct 15, 2018
Ks89 added a commit that referenced this issue Oct 15, 2018
Ks89 added a commit that referenced this issue Oct 21, 2018
Ks89 added a commit that referenced this issue Oct 21, 2018
@Ks89 Ks89 changed the title 7.0.0 Features/Roadmap - HUGE MAJOR RELEASE [BETA.2 IS COMING!!!] 7.0.0 Features/Roadmap - HUGE MAJOR RELEASE [BETA.3 IS COMING!!!] Oct 24, 2018
@Ks89
Copy link
Owner Author

Ks89 commented Oct 24, 2018

I need at least another beta to fix some stuff on mobile devices, before to go to RCs.

@Ks89
Copy link
Owner Author

Ks89 commented Oct 28, 2018

Beta 3 will be released in some days. I also added a new api to add responsive breakpoints to carousel's previews. This is a way to fix responsiveness on previous betas, but also a way to configure heights on previews.

@Ks89 Ks89 changed the title 7.0.0 Features/Roadmap - HUGE MAJOR RELEASE [BETA.3 IS COMING!!!] 7.0.0 Features/Roadmap - HUGE MAJOR RELEASE [RC.1 IS COMING!!!] Nov 1, 2018
@Ks89
Copy link
Owner Author

Ks89 commented Nov 1, 2018

Finally in beta 4, I fixed everything except for a stupid issue on IE11, that I'll fix before the final release.

Next releases will be RCs. If you want to use this library in your project, now you can, because apis are quite stable. Please give me all feedbacks.

@Ks89 Ks89 changed the title 7.0.0 Features/Roadmap - HUGE MAJOR RELEASE [RC.1 IS COMING!!!] 7.0.0 Features/Roadmap - HUGE MAJOR RELEASE [RC.1 IS OUT!!!] Nov 3, 2018
@Ks89
Copy link
Owner Author

Ks89 commented Nov 3, 2018

7.0.0 RC.1 released :)

The library is stable, or at least I hope.
I have to improve unit testing before the final release, but the library itself it will be the same as RC1

@Ks89 Ks89 changed the title 7.0.0 Features/Roadmap - HUGE MAJOR RELEASE [RC.1 IS OUT!!!] 7.0.0 Features/Roadmap - HUGE MAJOR RELEASE [RC.2 IS COMING!!!] Nov 6, 2018
@Ks89
Copy link
Owner Author

Ks89 commented Nov 6, 2018

I'm working on RC2 and hopefully the last RC before to release the final version.
I'm writing unit tests for the two new components. So in RC2 I'll improve input validation and so on, to prevent possible issues.

Please be patient. The final version will be released this month.

@Ks89
Copy link
Owner Author

Ks89 commented Nov 26, 2018

RC2 is out.
I'm sorry for the delay but I was really unexpectedly busy this month.
I'll release the final version in 1 or 2 weeks.

@Ks89 Ks89 changed the title 7.0.0 Features/Roadmap - HUGE MAJOR RELEASE [RC.2 IS COMING!!!] 7.0.0 Features/Roadmap - HUGE MAJOR RELEASE [STABLE RELEASE IS COMING!!!] Nov 28, 2018
@Ks89
Copy link
Owner Author

Ks89 commented Dec 6, 2018

7.0.0 will be released today evening :)

@Ks89 Ks89 closed this as completed Dec 6, 2018
@Ks89 Ks89 changed the title 7.0.0 Features/Roadmap - HUGE MAJOR RELEASE [STABLE RELEASE IS COMING!!!] 7.0.0 Features/Roadmap - HUGE MAJOR RELEASE Dec 6, 2018
@Ks89
Copy link
Owner Author

Ks89 commented Dec 6, 2018

7.0.0 final is finally available on npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment