Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output to ModalGalleryComponent emitting whenever the image is changed #165

Closed
srtab opened this issue Oct 15, 2018 · 6 comments
Closed

Comments

@srtab
Copy link

srtab commented Oct 15, 2018

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request
[ ] Support request

Current behavior

There's no way to know whenever the current image is changed. If the image is changed by clicking on the preview, i have no way to catch it. I only can catch when it's changed using keyboard or click on the arrows.

Expected behavior

Whenever the current image is changed, emit an output, either by keyboard, click on arrows or click on preview.

What is the motivation / use case for changing the behavior?

The use case is adding extra behavior whenever the image that the user is viewing, change. For instance: add custom event to analytics for tracking.

@Ks89
Copy link
Owner

Ks89 commented Oct 15, 2018

You are right.
I should trigger show/isLast/isFirst events also with previews.

I schedule this for 7.1.0, because I released 7.0.0 beta1 yesterday and I'm really busy to fix some issues before the final version of 7.0.0 and I don't want to add other stuff into that release.

@srtab
Copy link
Author

srtab commented Oct 15, 2018

Sorry, i accidentally closed the issue.

@srtab srtab reopened this Oct 15, 2018
@Ks89
Copy link
Owner

Ks89 commented Oct 16, 2018

No problem. I'll work on this in a couple of weeks, as soon after the release of 7.0.0 final

@Ks89
Copy link
Owner

Ks89 commented Nov 28, 2018

I'm sorry for the delay. 7.0.0 was really challenging. I released the last RC some days ago, so in a couple of weeks I'll release the final version.
7.1.0 will be released in December.

@srtab
Copy link
Author

srtab commented Nov 29, 2018

No problem @Ks89 :)

@Ks89
Copy link
Owner

Ks89 commented Dec 8, 2018

Implemented in 7.1.0. I want to release it tomorrow or Monday.

Issue closed, feel free to reopen if you'll have problems.

@Ks89 Ks89 closed this as completed Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants