Unit cases into integration suite #352
Labels
Comments
|
derived from the #282 |
4 tasks
|
This issue is stale because it has been open for 30 days with no activity. |
|
This issue was closed because it has been inactive for 30 days since being marked as stale. |
|
still valid issue |
|
This issue is stale because it has been open for 60 days with no activity. |
|
This issue was closed because it has been inactive for 30 days since being marked as stale. |
github-project-automation
bot
moved this from Todo
to Done
in Multicluster Gateway Controller
|
This issue is stale because it has been open for 60 days with no activity. |
|
This issue was closed because it has been inactive for 30 days since being marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What
Currently, we have a number of unit tests that are focused on the
.Reconcile()function. It was decided to delegate testing of the controllers mainly to the integration test suite hence some of the existing unit tests should be transitioned from the unit suite into integration.How
Go through the unit suite and transition all relevant cases.
The catch
Not all tests could be transitioned.
The goal is to have controllers mainly tested by the integration suite, but some of the logic in the
.Reconclile()ensures that we aren't crashing in case something goes wrong and integration isn't equipped well to deal with it. So should we still have a bunch of exception cases form the unit suite poking reconcilers or just get rid of them leaving certain parts of the code uncovered?The text was updated successfully, but these errors were encountered: