Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 0.3 manual docs testing #717

Closed
7 tasks done
maleck13 opened this issue Dec 12, 2023 · 4 comments
Closed
7 tasks done

release 0.3 manual docs testing #717

maleck13 opened this issue Dec 12, 2023 · 4 comments
Assignees
Milestone

Comments

@maleck13
Copy link
Contributor

maleck13 commented Dec 12, 2023

what

This covers a set of tests to execute as part of release testing around documentation. It does not cover every doc, the aim is to cover what we consider to be the core / most valuable user facing docs.

Process

There is a corresponding unified-kuadrant-layout branch of the docs also https://github.com/Kuadrant/docs.kuadrant.io/tree/unified-kuadrant-layout

Check out this branch and run the docs locally usinging mkdocs serve

@maleck13 maleck13 moved this to Todo in Kuadrant Dec 12, 2023
@maleck13 maleck13 added this to the v0.3.0 milestone Dec 12, 2023
@maleck13 maleck13 moved this from Todo to In Progress in Kuadrant Dec 12, 2023
@maleck13 maleck13 self-assigned this Dec 12, 2023
@david-martin
Copy link
Contributor

  • Follow the DNSPolicy health checks guide

following what I can from /docs/dnspolicy/dns-health-checks/, I patched the DNSPolicy after going through the multi cluster walkthrough:

[
  {
    "op": "add",
    "path": "/spec/healthCheck",
    "value": {
      "allowInsecureCertificates": true,
      "endpoint": "/",
      "expectedResponses": [200, 201, 301],
      "failureThreshold": 5,
      "port": 443,
      "protocol": "https"
    }
  }
]

kubectl patch dnspolicy prod-web --type=json --patch-file=patch.json -n multi-cluster-gateways

I'm not seeing any DNSHealthCheckProbe resources

kubectl get DNSHealthCheckProbe -A
No resources found

Here's the full DNSPolicy spec:

spec:
  healthCheck:
    allowInsecureCertificates: true
    endpoint: /
    expectedResponses:
    - 200
    - 201
    - 301
    failureThreshold: 5
    port: 443
    protocol: https
  routingStrategy: loadbalanced
  targetRef:
    group: gateway.networking.k8s.io
    kind: Gateway
    name: prod-web

dig and curl are working as expected for the HTTPRoute host echo.dm.hcpapps.net.

Full log of the policy controller here.

@maleck13
Copy link
Contributor Author

@david-martin ok I will give it a go here also to reproduce

@david-martin
Copy link
Contributor

@maleck13 The problem was the wildcard hostname in the Gateway listener.
I changed it to the full hostname and how the probes are created:

kubectl get -l kuadrant.io/gateway=prod-web dnshealthcheckprobes -A
NAMESPACE                NAME                        HEALTHY   LAST CHECKED
multi-cluster-gateways   172.31.201.0-prod-web-api   true      5s
multi-cluster-gateways   172.31.202.0-prod-web-api

I'll mark that test as OK now.

@maleck13 maleck13 moved this from Todo to In Progress in Multicluster Gateway Controller Dec 13, 2023
@maleck13
Copy link
Contributor Author

Yeah figured that out also. Added #726 as it is difficult to figure that out

@github-project-automation github-project-automation bot moved this from In Progress to Done in Kuadrant Dec 13, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Multicluster Gateway Controller Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants