KubeJS makes QSL's RecipeManagerHelper not working

[JieningYu]

Minecraft Version

1.18.2

KubeJS Version

1802.5.5-build.554

Rhino Version

18.2.2.1

Architectury Version

4.10.86

Forge/Fabric Version

Quilt Loader 0.17.6 + QSL 1.0.0-beta.26

Describe your issue

KubeJS's RecipeManagerMixin makes Quilt Standard Libraries' RecipeManagerMixin inject nothing and that makes QSL's RecipeManagerHelper stop working at all.

Crash report/logs

No response

[JieningYu]

I fixed this using a mixin to RecipeEventJS.

https://github.com/DM-Earth/KuSL-Recipe-Fix

[SplendidAlakey]

Might be affecting 1.19.2 as well, because I'm experiencing this: LambdAurora/AurorasDecorations#38

[JieningYu]

yep. I may make a 1.19.2 version of kusl recipe fix

[MaxNeedsSnacks]

While KubeJS itself will likely never directly support code recipes, and doesn’t particularly care about mods insisting on supporting them, the way the mixin works right now also prevents any other injections to RecipeManager.apply, which possibly breaks quite a few mods in the process; thus, the recipe event is (and has been) in dire need of a rework for a while now. Unfortunately neither I nor Lat have the time to sit down and do this, though, so things have stagnated on that front for a while.

Instead of layering yet another mixin on top though (which has broken compatibility and caused issues in the past), I would appreciate if someone could come up with a fix for this within KubeJS itself. I‘ve had multiple basic ideas in the past, including firing the JS event BEFORE RecipeManager.apply is called, queueing up the changes made it in and then applying them in multiple phases during the actual method (remove and replace I/O while loading the json map, add afterwards), but so far nothing has managed to make it past the planning stage…

[JieningYu]

QSL is a "base" api of quilt so that should be supported.