-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not delete soft lines (optionally?) #29
Comments
sorry, it is WithHardWraps |
Or we could actually automatically tell what max char length should it be (: |
Merged
5 tasks
Taking max width and breaking on that is a different thing from preserving current lines. Both would be fine :P I'm now kind of busy, PR welcome :D |
Merged
Looks like this is done with #36? Should this issue be closed? |
Done in #36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we put together newlines. That is
will be formatted as
This is basically correct.
https://spec.commonmark.org/0.29/#soft-line-breaks
However, as the spec says also,
I have now saw an issue in one project where those soft lines were actually interpreted as hard lines, and this option was "on by default", so these soft lines were actually important. (Related to nhn/tui.editor#1347 )
We can see goldmark for inspiration; goldmark has option WithHardLines for renderer; we can copy that directly almost.
The text was updated successfully, but these errors were encountered: