[GeneratorBundle] Kuma install command #1836
Conversation
cv65kr
force-pushed
the
feature/install
branch
3 times, most recently
from
aab6822
to
585f637
Compare
There was a problem hiding this comment.
@cv65kr What's the difference with the setupProject.sh command that already exists?
| use Sensio\Bundle\GeneratorBundle\Command\Helper\QuestionHelper; | ||
| use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand; | ||
| use Symfony\Component\Debug\Exception\ContextErrorException; | ||
|
|
| use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand; | ||
| use Symfony\Component\Debug\Exception\ContextErrorException; | ||
|
|
||
| class InstallCommand extends ContainerAwareCommand |
There was a problem hiding this comment.
For new commands, we don't extend the ContainerAwareCommand anymore. It should work with service injections.
| { | ||
| $this | ||
| ->setName('kuma:install') | ||
| ->setDescription('KunstmaanCMS installator.') |
|
@sandergo90, First of all, I wanted it to be consistent, without extra bash file. Secondly, we have less fields to fill, and also we can selected demosite install without bash file edit. If You think is not necessary, i will close this PR. |
|
@cv65kr Alright, maybe it's a good thing then! |
cv65kr
force-pushed
the
feature/install
branch
from
585f637
to
ef0773a
Compare
|
@sandergo90, Changed according to your guidelines. |
| */ | ||
| public function __construct(ContainerInterface $container) | ||
| { | ||
| $this->container = $container; |
There was a problem hiding this comment.
Symfony 4 is deprecating using the container directly, in the bundles we also have several attempts going on to remove all places where we are injecting and using the database. I do not think its a good idea to add new code which uses the container now. Better just inject the dependencies you want.
| $input->setOption('demosite', $demositeOption); | ||
| $input->setOption('bundle-name', strtr($namespace, ['\\Bundle\\' => '', '\\' => ''])); | ||
|
|
||
| $dir = $input->getOption('dir') ?: dirname($this->container->getParameter('kernel.root_dir')) . '/src'; |
There was a problem hiding this comment.
You do not need to inject the container to get this parameter. you can inject the parameter alone in the services.yml.
|
@cv65kr Do you have the time to finish this? Thanks! |
There was a problem hiding this comment.
Hi @cv65kr, your PR passed all our requirements.
Thank you for contributing!
Numkil
force-pushed
the
feature/install
branch
2 times, most recently
from
cab4f24
to
4f2a696
Compare
|
I updated changes I requested myself. Up to you guys if you still find it interesting to add this to the bundles or not. |
Devolicious
force-pushed
the
feature/install
branch
from
4f2a696
to
69147ba
Compare
There was a problem hiding this comment.
Hi @cv65kr, your PR needs some changes
- This PR seems to need a milestone of a minor release.
There was a problem hiding this comment.
Hi @cv65kr, your PR passed all our requirements.
Thank you for contributing!
Devolicious
changed the title
* master: (406 commits) [NodeBundle] Allow entity as creator (#2429) [AllBundle] Separate bundle phpunit config and cleanup old files (#2419) check if db_driver has been configured as it cannot be overwritten (#2425) [AdminBundle] dynamic breakpoint for top navbar in admin area (#2375) [AdminBundle] update Bootstrap v3.3 -> v3.4 (#2424) [Documentation] KunstmaanCMS Installer documentation (#2418) [AdminBundle] fix typo in filename of wordcount (#2423) [FormBundle] In newer versions of symfony the @templating service is changed to the delegatingengine instead of the twigengine (#2422) [AllBundles] Replace deprecated getRootDir calls (#2421) [NodeBundle] Remove old/incorrect doc about lock command (#2420) fix null check (#2417) [GeneratorBundle] Added config generator + improved install command (#2414) [NodeBundle] Import commands.yml to register command in sf4 (#2415) [NodeBundle] Fix for missing validation of url/email link chooser (#2413) [AllBundles] added link script for development (#2412) [DashboardBundle] Mark google analytics helper service as public (#2410) [NodeBundle] Start page reorder weight at 1 instead of 0 (#2411) [TranslatorBundle] csv export creates garbage on special signs (#2409) [NodeSearchBundle] fix #2380 childs of structurenodes never get indexed (#2395) [GeneratorBundle] Kuma install command (#1836) ...
Described in doc.