New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AdminBundle] Fix FOSUserBundle config prepend #2425
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Devolicious
commented
Apr 9, 2019
Q | A |
---|---|
Bug fix? | yes |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Fixed tickets |
ProfessorKuma
previously requested changes
Apr 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Devolicious, your PR needs some changes
- It seems that you should have submitted to the latest minor branch.
Devolicious
added a commit
that referenced
this pull request
Apr 10, 2019
* 5.2: check if db_driver has been configured as it cannot be overwritten (#2425) [AdminBundle] dynamic breakpoint for top navbar in admin area (#2375) [AdminBundle] update Bootstrap v3.3 -> v3.4 (#2424) [FormBundle] In newer versions of symfony the @templating service is changed to the delegatingengine instead of the twigengine (#2422) [NodeBundle] Remove old/incorrect doc about lock command (#2420) [NodeBundle] Import commands.yml to register command in sf4 (#2415) [NodeBundle] Fix for missing validation of url/email link chooser (#2413)
Devolicious
added a commit
that referenced
this pull request
Apr 18, 2019
* master: (406 commits) [NodeBundle] Allow entity as creator (#2429) [AllBundle] Separate bundle phpunit config and cleanup old files (#2419) check if db_driver has been configured as it cannot be overwritten (#2425) [AdminBundle] dynamic breakpoint for top navbar in admin area (#2375) [AdminBundle] update Bootstrap v3.3 -> v3.4 (#2424) [Documentation] KunstmaanCMS Installer documentation (#2418) [AdminBundle] fix typo in filename of wordcount (#2423) [FormBundle] In newer versions of symfony the @templating service is changed to the delegatingengine instead of the twigengine (#2422) [AllBundles] Replace deprecated getRootDir calls (#2421) [NodeBundle] Remove old/incorrect doc about lock command (#2420) fix null check (#2417) [GeneratorBundle] Added config generator + improved install command (#2414) [NodeBundle] Import commands.yml to register command in sf4 (#2415) [NodeBundle] Fix for missing validation of url/email link chooser (#2413) [AllBundles] added link script for development (#2412) [DashboardBundle] Mark google analytics helper service as public (#2410) [NodeBundle] Start page reorder weight at 1 instead of 0 (#2411) [TranslatorBundle] csv export creates garbage on special signs (#2409) [NodeSearchBundle] fix #2380 childs of structurenodes never get indexed (#2395) [GeneratorBundle] Kuma install command (#1836) ...
acrobat
added a commit
that referenced
this pull request
May 10, 2019
* master: (319 commits) [AdminListBundle] [TranslatorBundle] Option to filter on empty fields in StringFilterType. (#2434) fix admin test generator (#2432) Fix addField docblock param for AbstractAdminListConfigurator (#2433) [NodeBundle] Register services that enable the node bundle entity tabs (#2430) [GeneratorBundle] Added fos user config to generator (#2427) [NodeBundle] Allow entity as creator (#2429) [AllBundle] Separate bundle phpunit config and cleanup old files (#2419) check if db_driver has been configured as it cannot be overwritten (#2425) [AdminBundle] dynamic breakpoint for top navbar in admin area (#2375) [AdminBundle] update Bootstrap v3.3 -> v3.4 (#2424) [Documentation] KunstmaanCMS Installer documentation (#2418) [AdminBundle] fix typo in filename of wordcount (#2423) [FormBundle] In newer versions of symfony the @templating service is changed to the delegatingengine instead of the twigengine (#2422) [AllBundles] Replace deprecated getRootDir calls (#2421) [NodeBundle] Remove old/incorrect doc about lock command (#2420) fix null check (#2417) [GeneratorBundle] Added config generator + improved install command (#2414) [NodeBundle] Import commands.yml to register command in sf4 (#2415) [NodeBundle] Fix for missing validation of url/email link chooser (#2413) [AllBundles] added link script for development (#2412) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.