Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AllBundles] Replace deprecated getRootDir calls #2421

Merged
merged 1 commit into from Apr 8, 2019
Merged

[AllBundles] Replace deprecated getRootDir calls #2421

merged 1 commit into from Apr 8, 2019

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Apr 8, 2019

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets

@acrobat acrobat added this to the 5.3.0 milestone Apr 8, 2019
ProfessorKuma
ProfessorKuma approved these changes Apr 8, 2019
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

@Devolicious
Copy link
Contributor

Devolicious commented Apr 8, 2019 •
edited

@acrobat, SymfonyInsight has a good point, maybe you can also deprecate the versionchecker container injection? Or send a seperate PR? :)

@acrobat
Copy link
Member Author

acrobat commented Apr 8, 2019

@Devolicious yes indeed I also had the idea to do this, but I would suggest doing it in a separate pr (as it goes beyond the scope of this pr) to deprecate the container and do proper injection of all depedencies/parameters.

@Devolicious Devolicious merged commit 49c8b65 into Kunstmaan:master Apr 8, 2019
Devolicious added a commit that referenced this pull request Apr 18, 2019
@Devolicious
Merge branch 'master' into 6.0
8729c82 
* master: (406 commits)
  [NodeBundle] Allow entity as creator (#2429)
  [AllBundle] Separate bundle phpunit config and cleanup old files (#2419)
  check if db_driver has been configured as it cannot be overwritten (#2425)
  [AdminBundle] dynamic breakpoint for top navbar in admin area (#2375)
  [AdminBundle] update Bootstrap v3.3 -> v3.4 (#2424)
  [Documentation] KunstmaanCMS Installer documentation (#2418)
  [AdminBundle] fix typo in filename of wordcount (#2423)
  [FormBundle] In newer versions of symfony the @templating service is changed to the delegatingengine instead of the twigengine (#2422)
  [AllBundles] Replace deprecated getRootDir calls (#2421)
  [NodeBundle] Remove old/incorrect doc about lock command (#2420)
  fix null check (#2417)
  [GeneratorBundle] Added config generator + improved install command (#2414)
  [NodeBundle] Import commands.yml to register command in sf4 (#2415)
  [NodeBundle] Fix for missing validation of url/email link chooser (#2413)
  [AllBundles] added link script for development (#2412)
  [DashboardBundle] Mark google analytics helper service as public (#2410)
  [NodeBundle] Start page reorder weight at 1 instead of 0 (#2411)
  [TranslatorBundle] csv export creates garbage on special signs (#2409)
  [NodeSearchBundle] fix #2380 childs of structurenodes never get indexed (#2395)
  [GeneratorBundle] Kuma install command (#1836)
  ...
acrobat added a commit that referenced this pull request May 10, 2019
@acrobat
Merge branch 'master' into l10n_master
468a7fb 
* master: (319 commits)
  [AdminListBundle] [TranslatorBundle] Option to filter on empty fields in StringFilterType. (#2434)
  fix admin test generator (#2432)
  Fix addField docblock param for AbstractAdminListConfigurator (#2433)
  [NodeBundle] Register services that enable the node bundle entity tabs (#2430)
  [GeneratorBundle] Added fos user config to generator (#2427)
  [NodeBundle] Allow entity as creator (#2429)
  [AllBundle] Separate bundle phpunit config and cleanup old files (#2419)
  check if db_driver has been configured as it cannot be overwritten (#2425)
  [AdminBundle] dynamic breakpoint for top navbar in admin area (#2375)
  [AdminBundle] update Bootstrap v3.3 -> v3.4 (#2424)
  [Documentation] KunstmaanCMS Installer documentation (#2418)
  [AdminBundle] fix typo in filename of wordcount (#2423)
  [FormBundle] In newer versions of symfony the @templating service is changed to the delegatingengine instead of the twigengine (#2422)
  [AllBundles] Replace deprecated getRootDir calls (#2421)
  [NodeBundle] Remove old/incorrect doc about lock command (#2420)
  fix null check (#2417)
  [GeneratorBundle] Added config generator + improved install command (#2414)
  [NodeBundle] Import commands.yml to register command in sf4 (#2415)
  [NodeBundle] Fix for missing validation of url/email link chooser (#2413)
  [AllBundles] added link script for development (#2412)
  ...
@acrobat acrobat deleted the fix-root-dir-deprecations branch July 31, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Devolicious Devolicious Devolicious approved these changes

@ProfessorKuma ProfessorKuma ProfessorKuma approved these changes

Assignees
No one assigned
Labels
Priority: Normal Target audience: Developers Type: Improvement
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@acrobat @Devolicious @ProfessorKuma