[AdminListBundle] Sortable entities #2126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JZuidema
commented
Sep 14, 2018
JZuidema
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets |
…entity" This reverts commit 8d02457.
…#1936) * [SeoBundle]: change meta length (Kunstmaan#1520) [SeoBundle]: change translations * [SeoBundle] Refactor seo description to be longer according to google's new length (Kunstmaan#1797) * [NodeSearchBundle] [SearchBundle] ElasticSearch Backport so we can support bundles 3.6 websites on servers with ES6 (Kunstmaan#1877) * [NodeSearchBundle]: fix request scope * [NodeSearchBundle] Make NodeSearcher properties protected for extending * [NodeSearchBundle]: add possibility to index multiple regions [NodeSearchBundle]: make contexts default array, and merge default * [KunstmaanNodeSearchBundle]: upgrade elastica to 5.1 Change ruflin elastica version [KunstmaanNodeSearchBundle]: upgrade elastica to 5.1 Add changelog * move boost from mapping to query + allow text as type for elasticsearch 5.0 * [NodeSearchBundle] Bugfix for indexing StructuredNodes and children (Kunstmaan#1550) [NodeSearchBundle] Bugfix for indexing StructuredNodes and children * [NodeSearchBundle] Bugfix for indexing StructuredNodes and children * [NodeSearchBundle][SearchBundle] Multi domain/language search population fix (Kunstmaan#1635) * squash commits * Analyzer info in command * Typo fix * typo * [NodeSearchBundle]: check if we have html * [NodeSearchBundle] shards and replicas configurable [NodeSearchBundle] default values shards/replicas * [SearchBundle][FIX] Populate command failing * [SearchBundle] Convert analyzer languages config to lowercase to prevent config mismatch because of case sensitivity * [SearchBundle] SetupIndex command failing when overwriting nodeconfiguration with own file. * [SearchBundle][FIX] SetupIndex command failing * [SearchBundle][FIX] SetupIndex command failing * [SearchBundle][FIX] SetupIndex command failing * [SearchBundle] add punctuation to kuma_ngram tokenizer * [NodeSearchBundle] added extra properties for elasticsearch mapping (Kunstmaan#1794) * [KunstmaanNodeSearchBundle] add keyword as data type (Kunstmaan#1793) [KunstmaanNodeSearchBundle]: change data types Revert keyword to string for compability with 2.4 * [NodeSearchBundle] Elastic search version 6 support * [NodeSearchBundle] Elastic search version 6 support * [NodeSearchBundle] backport fixes * [allbundles] bump phpversions * update changelog * [AdminlistBundle] fixed type from string to array (Kunstmaan#1925)
…on of elasticsearch (Kunstmaan#1940) (Kunstmaan#1965) Cache es version info Change check priority (cherry picked from commit 6c4503c)
Kunstmaan#1939) * [UtilitiesBundle] Make parameter kunstmaan_utilities.cipher.secret optional
ProfessorKuma
suggested changes
Sep 14, 2018
There was a problem hiding this comment.
Hi @JZuidema, your PR needs some changes
- This PR seems to need a milestone of a patch release.
ProfessorKuma
approved these changes
Sep 14, 2018
There was a problem hiding this comment.
Hi @JZuidema, your PR passed all our requirements.
Thank you for contributing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.