feat: add database accessory #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adohe
reviewed
Aug 4, 2023
SparkYuan
reviewed
Aug 7, 2023
liu-hm19
force-pushed
the
feat/add-database-accessory
branch
from
f1a84f3
to
e28fe52
Compare
adohe
reviewed
Aug 19, 2023
|
except for supporting cloud provider managed database, is there any plan to support local deploy instance? From SDLC, the most common way during development and test stages is using local database, as they are much more cheaper than services provided by cloud providers. @ffforest @liu-hm19 @SparkYuan |
adohe
reviewed
Aug 25, 2023
adohe
reviewed
Aug 28, 2023
liu-hm19
changed the title
liu-hm19
force-pushed
the
feat/add-database-accessory
branch
from
76ec6fa
to
70c24fe
Compare
ffforest
reviewed
Aug 29, 2023
ffforest
reviewed
Aug 29, 2023
ffforest
reviewed
Aug 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds support for database accessory which defines the relational database service (rds) provided by a specified cloud vendor.
Which issue(s) this PR fixes:
Special notes for your reviewer:
The implementation of Database Generator can be found at feat: add database generator
Does this PR introduce a user-facing change?
Additional documentation e.g., design docs, usage docs, etc.: