Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overload Material.addNuclide to allow atom fractions and weight fractions #150

Closed
KyleVaughn opened this issue Feb 6, 2024 · 2 comments
Closed

Overload Material.addNuclide to allow atom fractions and weight fractions #150

KyleVaughn opened this issue Feb 6, 2024 · 2 comments
Labels
good first issue Good for newcomers priority: medium type: enhancement New feature or request

Comments

@KyleVaughn
Copy link
Owner

Currently nuclides are added to a material using the number density, which is not always the easiest to compute.
@KyleVaughn KyleVaughn added type: enhancement New feature or request good first issue Good for newcomers priority: medium labels Feb 6, 2024
@KyleVaughn KyleVaughn changed the title Overload Material.addNuclide to allow atom fractions or weight fractions Overload Material.addNuclide to allow atom fractions and weight fractions Feb 6, 2024
@KyleVaughn
Copy link
Owner Author

A Material.addNuclideWt function, which takes a weight percent has been merged into main. We still need an atom fraction function.

Should we create 3 different functions, or use a single function which maybe takes an enum with {NumberDensity, AtomPercent, WeightPercent}? We should look at other open source codes for inspiration.

@KyleVaughn
Copy link
Owner Author

Added in #161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers priority: medium type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KyleVaughn