Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Full Chat [Save Failed] #3

Closed
juliofmendes opened this issue Feb 3, 2023 · 10 comments
Closed

Save Full Chat [Save Failed] #3

juliofmendes opened this issue Feb 3, 2023 · 10 comments

Comments

@juliofmendes
Copy link

First of all, congratulations on the project. It has helped me a lot.

In some chats, not all, I've been having problems saving the entire dialog.
Would there be any solution?
Thanks.

@L-a-r-t
Copy link
Owner

L-a-r-t commented Feb 4, 2023

Hi, thanks for opening an issue for this, I'm glad that the extension is useful to you!

Can you tell me more about the chats where the saving process fails : how long are they (approximately)? Do they contain some kind of special formatting (tables, etc.)?

I'm not aware of a specific saving issue at the moment, but if there's one it might be due to one of these factors. I'll work on fixing this ASAP!

@juliofmendes
Copy link
Author

For sure.

I'm using a Macbook with Chrome Version 109.0.5414.119. I couldn't identify anything unusual, in fact the database table was set up similarly to the example.

In some chats created, when clicking on [Save full Chat], in a few seconds of processing it displays the result [Discussion Saved]. However, in other chats created, when clicking on [Save full Chat], in a few seconds of processing it presents the result [Save Failed].

Analyzing the chats, one of the possibilities would be the size or the number of entries. One of them had more than 10 entries. Another possibility may be that some of these entries have been rewritten. Leaving the first ones hidden and showing the marker <2/2> or <3/3>.

@L-a-r-t
Copy link
Owner

L-a-r-t commented Feb 4, 2023

Thanks a lot for the additionnal info. ATM the extension saves the whole conversation in one API call which won't work with very long conversations, I will be working on a fix tomorrow & it should be published within a 48hrs window.

I will also investigate the behavior of the extension with rewritten entires in case there is something breaking here too, thanks again for your feedback!

@juliofmendes
Copy link
Author

Excellent. And thank you for your attention.
Let me know when you make the changes so I can look into it and give you more feedback.

@L-a-r-t
Copy link
Owner

L-a-r-t commented Feb 7, 2023

It took more time than usual for the new release to be verified but it's finally public.
The issue with long conversations was that Notion doesn't allow more than 100 blocs to be generated in one API call, so longer conversations are now split into multiple calls and it works fine!

I'm not yet closing this issue as I need to know if saving still fails with other types of conversations

@juliofmendes
Copy link
Author

Hey Theo!
Perfectly understandable. This kind of process sometimes takes a long time.

From my quick analysis, these tweaks had good results. Some of the Chats that were not saved, now its saved. However, I'm afraid I ran into another possible problem in this context.

In some cases, the free version does not remember previous entries, forcing us to copy the output and attach it to the question. This makes the prompt's question very large, and may cause an error in saving. At least that's what I was able to observe when the error appeared.

@juliofmendes
Copy link
Author

Update.
I tested my theory in another chat and it saved correctly. I cannot claim that my theory is correct.

@L-a-r-t
Copy link
Owner

L-a-r-t commented Feb 15, 2023

Hi, I saw your comments while being busy with something else, sorry for not answering!

It seems like there are still some instances of save failing although I haven't been able to find any reason or pattern for this yet. Have you been able to save the chat that had an issue with after all?

Although the problem isn't exactly 100% fixed, I will be closing this issue for now until another clear instance of the saving process failing is found in a specific situation.

@L-a-r-t
Copy link
Owner

L-a-r-t commented Feb 15, 2023

Quick update: I still wanted to inspect your intuition with long prompts & found that the Notion API doesn't allow blocks with a length > 2000 characters to be generated, which does causes an issue with very long prompts and may affect some instances of ChatGPT answering with a very long paragraph (i guess).

I will be releasing a hotfix in the following hours

@L-a-r-t L-a-r-t closed this as completed Feb 20, 2023
@juliofmendes
Copy link
Author

Hello Théo, sorry for not answering sooner.
In my last tests there were no errors. I believe that for now everything is going well. I think it's okay to close this topic.
Thank you for your attention! Hugs.

@spurin spurin mentioned this issue Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants