Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified multiple Docker Compose files into one for easier usage #119

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

croumegous
Copy link
Collaborator

Remove all the different docker compose files in scripts folder, to use a single docker compose (in root directory).
Also moved documentation to run the end to end demo in the main readme to better onboard new users.

Copy link
Collaborator

@fozziethebeat fozziethebeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is quite a bit cleaner and resolves a lot of cross compose referencing. As long as my question/comment does what I think it does, I like this.

You'll still need review from Yannic or Andreas to finish.

@@ -0,0 +1,101 @@
version: "3.7"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume docker compose up would bring up the full stack yes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, exactly

Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants