Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: rename database objects #182

Merged
merged 14 commits into from Dec 30, 2022
Merged

BREAKING CHANGE: rename database objects #182

merged 14 commits into from Dec 30, 2022

Conversation

andreaskoepf
Copy link
Collaborator

This should complete the work started by @alexandrelefourner to rename several database objects/models.

person -> user
work_package -> task
post -> message
thread -> message_tree

@andreaskoepf andreaskoepf mentioned this pull request Dec 30, 2022
Closed
mjagkow
mjagkow reviewed Dec 30, 2022
View reviewed changes
Copy link
Collaborator

@mjagkow mjagkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of issues, other looks good

backend/main.py Outdated Show resolved Hide resolved
backend/oasst_backend/exceptions.py Outdated Show resolved Hide resolved
backend/oasst_backend/prompt_repository.py Outdated Show resolved Hide resolved
backend/main.py Outdated Show resolved Hide resolved
@k-nearest-neighbor
Copy link
Collaborator

Have tested web up to this point / looked for anything to rename on the web side. No issues so far.

(Shows we have some work to do to hooking up the website to the api)

yk
yk approved these changes Dec 30, 2022
View reviewed changes
Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huge props, thank you very much!

@andreaskoepf andreaskoepf merged commit 1595e8e into main Dec 30, 2022
@andreaskoepf andreaskoepf deleted the 124_rename_database_objects branch December 30, 2022 23:18
@andreaskoepf
Copy link
Collaborator Author

closes #124

@k-nearest-neighbor k-nearest-neighbor mentioned this pull request Dec 31, 2022
Merged
fozziethebeat added a commit that referenced this pull request Dec 31, 2022
@fozziethebeat
Merge pull request #188 from k-nearest-neighbor/fixes_for_breaking_ch…
491b1f6 
…ange_182

Fixes for breaking changes in #182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjagkow mjagkow mjagkow left review comments

@yk yk yk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andreaskoepf @k-nearest-neighbor @yk @mjagkow @alexandrelefourner