Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for breaking changes in #182 #188

Merged

Conversation

k-nearest-neighbor
Copy link
Collaborator

This PR gathers any fixes needed from #182.

@k-nearest-neighbor
Copy link
Collaborator Author

k-nearest-neighbor commented Dec 31, 2022

Here is a summary of the renamings from #182

  • Fixed "user_reply" -> "prompter_reply"
  • Fixed "rank_user_replies" -> "rank_prompter_replies"

The API endpoints for these tasks was updated. For now I left the UI and filenames using the name "user". (e.g., the UI still says "Reply As User" instead of "Reply as Prompter") as I think that while "prompter" is a good model name, it might make for awkward UX as a user-facing string. However, if we want it to match in the UI ("Reply as Prompter"), I don't object. Let's just confirm first that we want the UX to call humans "prompters" instead of "users".

  • Fixed post_id -> message_id (in TaskAck, TaskClose)
  • Fixed user_post_id -> user_message_id

Updated in [task_type].ts and update_task.ts.

  • Fixed "post_rating" -> "message_rating"
  • Fixed "post_ranking" -> "message_ranking"

Updated in rank_user_replies.tsx rank_initial_promps.tsx, rank_assistant_replies.tsx update_tasks.tsx

  • Fixed "text_reply_to_post" -> "text_reply_to_message"

Updated in assistant_reply.ts summarize_story.tsx user_reply.tsx

Copy link
Collaborator

@fozziethebeat fozziethebeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

@fozziethebeat fozziethebeat merged commit 491b1f6 into LAION-AI:main Dec 31, 2022
@k-nearest-neighbor k-nearest-neighbor deleted the fixes_for_breaking_change_182 branch December 31, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants