Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace fonts loaded via stylesheet with use of next/font #2600

Merged
merged 6 commits into from Apr 16, 2023
Merged

Replace fonts loaded via stylesheet with use of next/font #2600

merged 6 commits into from Apr 16, 2023

Conversation

spencerwmiles
Copy link
Contributor

Solves #1832

I wasn't sure to use local font or just use google font. I can undo that change if use of Google font is undesirable

@github-actions
Copy link

❌ pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

notmd
notmd reviewed Apr 16, 2023
View reviewed changes
Copy link
Collaborator

@notmd notmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

website/package.json Show resolved Hide resolved
@spencerwmiles spencerwmiles changed the title 1832 next font Replace fonts loaded via stylesheet with use of next/fonty Apr 16, 2023
@spencerwmiles spencerwmiles changed the title Replace fonts loaded via stylesheet with use of next/fonty Replace fonts loaded via stylesheet with use of next/font Apr 16, 2023
@notmd notmd merged commit e7cf828 into LAION-AI:main Apr 16, 2023
4 checks passed
@spencerwmiles spencerwmiles deleted the 1832-next-font branch April 16, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmd notmd notmd approved these changes

@AbdBarho AbdBarho Awaiting requested review from AbdBarho AbdBarho is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spencerwmiles @notmd