Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load font using next/font #1832

Closed
notmd opened this issue Feb 24, 2023 · 3 comments
Closed

Load font using next/font #1832

notmd opened this issue Feb 24, 2023 · 3 comments
Labels
good first issue Good issue for project newcomers website

Comments

@notmd
Copy link
Collaborator

notmd commented Feb 24, 2023

Open-Assistant/website/src/styles/globals.css

Line 11 in d897be9

src: url("/fonts/Inter-roman.var.woff2") format("woff2");

We are loading font in CSS but using next/font will improve a lot loading performance
@notmd notmd added website good first issue Good issue for project newcomers labels Feb 24, 2023
@CheckMC
Copy link
Contributor

CheckMC commented Feb 25, 2023

I can work on this one

@notmd
Copy link
Collaborator Author

notmd commented Feb 25, 2023

@CheckMC thanks, it's yours!

@CheckMC CheckMC removed their assignment Mar 22, 2023
@spencerwmiles
Copy link
Contributor

@notmd I'll take this if @CheckMC is no longer interested!

@spencerwmiles spencerwmiles mentioned this issue Apr 16, 2023
Merged
notmd pushed a commit that referenced this issue Apr 16, 2023
@spencerwmiles
Replace fonts loaded via stylesheet with use of next/font (#2600)
e7cf828 
Solves #1832 

I wasn't sure to use local font or just use google font. I can undo that
change if use of Google font is undesirable
@notmd notmd closed this as completed Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good issue for project newcomers website
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@spencerwmiles @notmd @CheckMC