Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website implement create initial prompt #329

Merged

Conversation

othrayte
Copy link
Collaborator

@othrayte othrayte commented Jan 3, 2023

In think this implements #275, thought it seemed a bit easy so maybe I missed something.

I think someone should look over the instructions on the page, maybe we can come up with something better.

Also the e2e tests got broken when the data-cy attributes disappeared from the elements. Note sure what happened, I can even find them being removed in the git history 🤷‍♂️.

Copy link
Collaborator

@AbdBarho AbdBarho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@othrayte thank you!

tested it locally and it works.

I think we should activate the e2e tests as part of the CI.

for the instruction, we have #159. If you have any ideas, please add them there.

@AbdBarho AbdBarho merged commit 1970b43 into LAION-AI:main Jan 3, 2023
@othrayte othrayte deleted the website-implement-create-initial-prompt branch January 3, 2023 22:05
@othrayte
Copy link
Collaborator Author

othrayte commented Jan 3, 2023

@AbdBarho, agree totally, I started working on #274 as soon as I submitted this PR, I'm getting there but might need some help with using docker compose in GitHub actions, or else some better way to run the stack to test it. If that fits anyone's skillset message me in the open assistant discord (otherwise I'll probably post there with some questions once I'm back working on the task after work).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants