-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement user_ranking_scoreboard for web #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a helpful skeleton. Could you get https://pre-commit.com/ setup and have it auto-tidy up all the files? That'll help keep automate some of the simple style consistency changes we hope to maintain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I just have a few small style requests.
@@ -0,0 +1,53 @@ | |||
import RankItem from "@/components/LeaderBoardItem"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the URL, maybe we can just call this leaderboard/score.tsx
. I'm not sure we need to have leaderboard twice in the url.
Please resolve the changes in |
done merged and resolved changes |
[WIP]
Pull request for #51
Notes: