Implement user_ranking_scoreboard for web #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poipiii
requested review from
fozziethebeat and
k-nearest-neighbor
as code owners
fozziethebeat
requested changes
Dec 23, 2022
There was a problem hiding this comment.
This is a helpful skeleton. Could you get https://pre-commit.com/ setup and have it auto-tidy up all the files? That'll help keep automate some of the simple style consistency changes we hope to maintain.
fozziethebeat
requested changes
Dec 27, 2022
| @@ -0,0 +1,53 @@ | |||
| import RankItem from "@/components/LeaderBoardItem"; | |||
There was a problem hiding this comment.
For the URL, maybe we can just call this leaderboard/score.tsx. I'm not sure we need to have leaderboard twice in the url.
fozziethebeat
approved these changes
Dec 27, 2022
|
Please resolve the changes in |
done merged and resolved changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP]
Pull request for #51
Notes: