Prettier User Choice on index page #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucianPetri
requested review from
fozziethebeat and
k-nearest-neighbor
as code owners
|
Finished the Component, in case it looks better without the grayscale text just have undo last commit. IMO looks cooler now. |
fozziethebeat
requested changes
Dec 27, 2022
|
Ok, I added a TaskSelection, TaskOptions and TaskOption Component. Didn't want clutter the index so I threw everything in the TaskSelection Logic. Also merged the new paths and added them. |
|
On the way, I also found that the Footer overlaps when on mobile screen while having multiple tasks. I Can do this after. |
|
Also if there's to be added more stuff on index page, I have in mind another style to view the task selection to give more room for other stuff to be added. Hit me up with more details if required. |
LucianPetri
commented
Dec 27, 2022
fozziethebeat
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is linked to this issue: Better UI Choice #74