Add per-page layout #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdBarho
requested review from
fozziethebeat and
k-nearest-neighbor
as code owners
|
I'll review this after my PR finally goes in. |
website/src/components/Layout.tsx
Outdated
| getLayout?: (page: React.ReactElement) => React.ReactNode; | ||
| }; | ||
|
|
||
| export const getLayout = (page: React.ReactElement) => ( |
There was a problem hiding this comment.
This component is pretty magical. Can you add some high level comments on how it works. My understanding is that any new page component should set a getLayout field and use this method. That'll use this one unified layout.
Should we name this as something a little more specific like getDefaultLayout in the situation where we have another layout?
There was a problem hiding this comment.
You are totally right, I changed it now so it is the default global layout (you don't have to specify anything in the components), with the option of overriding if needed.
with the ability to be overridden per-page
fozziethebeat
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the discussion in #76
Some layout fixes are necessary, mainly removing the
h-full mx-auto.