Unifying the task structure #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… types, and fixing a ui bug in the rating task
This was
linked to
issues
Dec 27, 2022
|
would it be simpler to use layouts for the header and footer? |
|
I like that idea. If this doesn't get reviewed tomorrow I'll add that in. otherwise I'll add it in another PR. If you want, could you create some layouts in a separate PR and then I'll use them? |
It'll be a good time to test rebase vs merge practices... Can you make a comment in #30 and #31? I can't seem to assign them to you right now but I will as soon as Github lets me. |
Merged
fozziethebeat
requested review from
yk and
AbdBarho
and removed request for
yk
andreaskoepf
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the existing tasks to a simpler url hierarchy:
/evaluateand/create. We rename the pages to match the underlying task names in the backend.Further, this adds some UI layout to the tasks so users can navigate to the home page without struggle and fixes the UI highlighting for the rating task.