Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IP Whitelist Endpoint Filter #61

Merged
merged 6 commits into from
May 9, 2024
Merged

Add IP Whitelist Endpoint Filter #61

merged 6 commits into from
May 9, 2024

Conversation

notatiyyah
Copy link
Contributor

Describe this PR

In the Contact Details API, we recently implemented an IP whitelist feature that limits an endpoint to only be accessed by certain IP addresses. This PR moves this functionality to Hackney.Core.Authorization if it needs to be used for other projects.

Checklist

  • Added tests to cover all new production code
  • Added comments to the README or updated relevant documentation (add link to documentation), where necessary.
  • Checked all code for possible refactoring
  • Code pipeline builds correctly

@notatiyyah notatiyyah mentioned this pull request May 2, 2024
Merged
4 tasks
@notatiyyah notatiyyah merged commit 6392026 into release May 9, 2024
5 checks passed
@notatiyyah notatiyyah deleted the feature/add-IpWhitelistAuth branch May 9, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humulla humulla humulla left review comments

@Duslerke Duslerke Duslerke left review comments

@LBHCallumM LBHCallumM LBHCallumM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@notatiyyah @humulla @Duslerke @LBHCallumM