Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site crashes on load when using Safari on iOS #3

Closed
LBlend opened this issue Dec 23, 2020 · 4 comments
Closed

Site crashes on load when using Safari on iOS #3

LBlend opened this issue Dec 23, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@LBlend
Copy link
Owner

LBlend commented Dec 23, 2020

image

See vercel/next.js#8347 for a potential solution

@LBlend LBlend added the bug Something isn't working label Dec 23, 2020
@marksverdhei
Copy link
Collaborator

marksverdhei commented Jan 9, 2021

The server should host the app with serve -s build after calling npm run-script build (instead of using npm start).
It might prohibit the site from breaking (which is better), so we should try to reproduce it after doing this
Make sure to npm install -g serve first

@LBlend
Copy link
Owner Author

LBlend commented Jan 13, 2021

The server should host the app with serve -s build after calling npm run-script build (instead of using npm start).
It might prohibit the site from breaking (which is better), so we should try to reproduce it after doing this
Make sure to npm install -g serve first

I will check whether or not this resolves the issue when I can get a hand on an iOS device. Probably by 2020-01-22.

I'll report back to you then.

@LBlend LBlend self-assigned this Jan 13, 2021
@LBlend
Copy link
Owner Author

LBlend commented Jan 18, 2021

The server should host the app with serve -s build after calling npm run-script build (instead of using npm start).
It might prohibit the site from breaking (which is better), so we should try to reproduce it after doing this
Make sure to npm install -g serve first

I will check whether or not this resolves the issue when I can get a hand on an iOS device. Probably by 2020-01-22.

I'll report back to you then.

Ok so I've tested the website and the error doesn't occur when the website is built. We should still consider fixing the issue though.

Even though I'm not 100% confident in what the issue is casued by, it is probably caused by this. If this is the issue I suggest we fix it by doing the following:

  • Delay sending of text to the API until the user has stopped typing anything for x seconds
  • Prevent text being sent to the API when the textbox is blank

By implementing the idea that I have proposed in the first bullet point, you can address the 2nd point at the same time. I actually implemented this feature in early builds of this project but decided to get rid of it before the initial commit due to complications.

@LBlend LBlend removed their assignment Jan 19, 2021
@LBlend
Copy link
Owner Author

LBlend commented Dec 12, 2021

Since we're doing a rewrite, this won't be an issue anymore.

@LBlend LBlend closed this as completed Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants