Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure on old R release #167

Closed
osorensen opened this issue Oct 11, 2023 · 1 comment
Closed

Failure on old R release #167

osorensen opened this issue Oct 11, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@osorensen
Copy link
Collaborator

The package fails on old R releases, i.e., on R4.2.3. This happens because the family objects don't have a dispersion element prior to R4.3.0.

Here is the code causing error:

galamm/R/galamm.R

Lines 460 to 461 in 7cd848a

df = length(opt$par) +
sum(vapply(family_list, function(x) is.na(x$dispersion), logical(1))),

Here is the fix:

galamm/R/galamm.R

Lines 460 to 464 in fa2af07

df = length(opt$par) +
sum(vapply(
family_list,
function(x) !x$family %in% c("binomial", "poisson"),
logical(1))),

@osorensen osorensen added the bug Something isn't working label Oct 11, 2023
@osorensen
Copy link
Collaborator Author

Solved by #168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant