Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload source measurements #49

Closed
zemogle opened this issue Nov 2, 2015 · 3 comments
Closed

Upload source measurements #49

zemogle opened this issue Nov 2, 2015 · 3 comments
Assignees
Milestone

Comments

@zemogle
Copy link
Contributor

zemogle commented Nov 2, 2015

We need a form which will parse output from Astrometrica and save it as multiple Source Measurements. We also will need to display these Source Measurements in 80 char, monospaced format.

@zemogle zemogle self-assigned this Nov 2, 2015
@talister talister added this to the Version 1.2 milestone Nov 5, 2015
@talister
Copy link
Member

talister commented Dec 7, 2015

Edward, I have created and pushed a new branch, create_mpc_80char_export, which builds on your current work and achieves the following 2 things from issue #52:

  • synthesize and display MPC 80-column format lines from the stored source measurements
  • Handle and search for Bodies with a packed designations
    The 'Upload MPC Report form' now works with the limited amount of testing I've done so far.

I think it would be nice to improve/change the mpcreport.html template a little bit. Given that the MPC format is a fixed format, I think it would be good to switch to a monospace font for the display and it would also be helpful to change the background or add a border around the report lines so that the important spaces at the start of the line show up more easily.

When I started this branch, I intended to add a 'Export Measurements' link to the Body page below the 'Show Measurements' (and indeed have an uncommitted FT and code for this...) but then I found that you had already started something very similar so wanted to check before proceeding further and duplicating code... Currently the 'View MPC Report' achieves what I want by showing all measurements (not just LCO ones) for the object, but given that you built it as a Block function, I'm guessing this isn't quite what you had in mind.

@zemogle
Copy link
Contributor Author

zemogle commented Dec 8, 2015

You're right I have started this already (I then got dragged into making a new theme for the main LCO website...).

I was basing the 80 col MPC report from a block because there is a direct link between this and an MPC report. It probably doesn't hurt to have the ability to have both, but I won't do any more on the block code just yet unless you think its useful.

I've adapted your code, including making the URL structure more canonical and adding 80 col format, and committed it.

I suggest you stash your changes with git stash, pull down my commits and git stash apply to get your uncommitted changes back. It will hopefully mean you don't have any nasty merges to do.

@zemogle
Copy link
Contributor Author

zemogle commented Dec 9, 2015 via email

@zemogle zemogle closed this as completed Feb 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants