Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to conda installation of oncopipe #175

Closed
rdmorin opened this issue Mar 16, 2021 · 6 comments
Closed

switch to conda installation of oncopipe #175

rdmorin opened this issue Mar 16, 2021 · 6 comments
Assignees

Comments

@rdmorin
Copy link
Collaborator

rdmorin commented Mar 16, 2021

India suggested we should change LCR-modules to use conda to install oncopipe, which should help ensure the dependencies are met. In order to switch to using conda to install oncopipe we need a way to directly create a conda release for any new oncopipe release.

@oncogenomics
Copy link

It looks like the bioconda release is up to date with our current version (v1.0.11): https://anaconda.org/bioconda/oncopipe
Conda-bot should update within a day or so if we release a new version.
If we use conda to install (rather than pip) when we run lcr-modules we can take advantage of their nice dependency resolution, and optimizations.
I will try running the Bioconda package on Thanos after my meetings today and if it works smoothly I will update the lcr-modules docs.

@rdmorin
Copy link
Collaborator Author

rdmorin commented Mar 16, 2021

Can you determine what date the conda package with that version appeared? I don't think we can assume the lag will only be a few days. We should be certain that it's within an acceptable (ideally consistent) time frame.

@oncogenomics
Copy link

Laura last updated the oncopipe version on December 5th 2020 and the oncopipe bioconda package was last updated January 11th 2021.

@oncogenomics
Copy link

Here is the update v1.0.11 oncopipe PR on bioconda.

The Conda Bot submits a PR to the bioconda repo (this took roughly 1 month) and then the PR needs to be manually reviewed (roughly 5 days) and merged (0 days).

Skipping the bot and doing a manual PR would have shaved a month off of the update time. We would shave 4 days off by formatting the package with artifacts cleanly included.

@rdmorin
Copy link
Collaborator Author

rdmorin commented Mar 17, 2021

What do you mean by artifacts?

@oncogenomics
Copy link

Artifact is a general software development term. In this case we would need to do small tidying like removing pip install dependencies and replacing them with conda dependencies, and integration with their CircleCI packaging scripts.

@Kdreval Kdreval closed this as completed Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants