Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use "million" placeholder #4590

Closed
apple502j opened this issue Nov 3, 2020 · 4 comments
Closed

Do not use "million" placeholder #4590

apple502j opened this issue Nov 3, 2020 · 4 comments

Comments

@apple502j
Copy link
Contributor

Some languages like Japanese don't have corresponding words for them in some cases.

Example:

  • 1 million -> 100万 (can be cheated by translating "million" to 00万, but gives Transifex warning)
  • 100 million -> 1億 (errors because we can't use million placeholder, but Transifex requires it)
  • 170 million -> 1億7000万

Please include the entire number, instead of using placeholders, or at least make it so that you can omit placeholders.

@Kenny2github
Copy link
Contributor

Chinese translators I know handle this by using 百萬(tw)/百万(cn) as "million". It makes it a bit awkward because "100 million" → "100 百万" → "one hundred hundred myriad" but that's no less awkward than "thousand million million" to avoid the whole quadrillion/billiard confusion.

@chrisgarrity
Copy link
Contributor

chrisgarrity commented Nov 5, 2020

@apple502j @Kenny2github {million} is currently a placeholder in the annual-report to allow for formatting in the reach section of the page. Here's the layout:
Screen Shot 2020-11-05 at 2 24 17 PM
Note, we cannot simply add the HTML formatting to the string as that feature is deprecated. We are not adding any new strings with embedded HTML.

Also note that simply leaving out the space in the translation is probably not doing what you expect:
Screen Shot 2020-11-05 at 2 34 57 PM

Warnings are there to make sure you check for common mistakes. They can be ignored when the common mistake is not applicable. You would have to ignore warnings for all of the strings, but you could use 万 as the translation for 'million' and change the number to 17000, 6000, etc.

@apple502j
Copy link
Contributor Author

@chrisgarrity Warnings are fine, but if we didn't use placeholders at all, the translation doesn't seem to save.

@chrisgarrity
Copy link
Contributor

@apple502j correct, you cannot remove the placeholder, and we are not going to remove the placeholder because it allows us to format the content correctly.

The suggestion is to translate million as 万, not 00万.
Then translate '170 {million}' as '1億7000 {million}' When formatted, '1億7000' would be the larger first line and '万' would be the second line.

However, this is really about how to translate the strings. The placeholder is in the code for a valid reason, so there's nothing to "fix" and I'm going to close the issue. Discussion of how to translate the placeholder can continue in transifex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants